Skip to content

Update Batch Service api version to 2025-06-01#2990

Merged
zfengms merged 12 commits intomainfrom
zfeng/generateclient20250601
Nov 11, 2025
Merged

Update Batch Service api version to 2025-06-01#2990
zfengms merged 12 commits intomainfrom
zfeng/generateclient20250601

Conversation

@zfengms
Copy link
Contributor

@zfengms zfengms commented Nov 5, 2025

Generate Rest Level Client for api version 2025-06-01 using azure-rest-api-specs PR branch
Fix build errors by removing node communication mode related code

@dpwatrous
Copy link
Member

/azp run BatchExplorer - CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 47.50000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.30%. Comparing base (ccf3a6e) to head (042a30e).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...nternal/batch-rest/generated/src/paginateHelper.ts 50.00% 17 Missing and 1 partial ⚠️
...c/internal/batch-rest/generated/src/batchClient.ts 33.33% 0 Missing and 2 partials ⚠️
.../arm-batch-rest/generated/batchManagementClient.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2990      +/-   ##
==========================================
- Coverage   80.34%   80.30%   -0.04%     
==========================================
  Files        1462     1462              
  Lines       46115    46181      +66     
  Branches     5773     5785      +12     
==========================================
+ Hits        37049    37084      +35     
- Misses       8883     8910      +27     
- Partials      183      187       +4     
Files with missing lines Coverage Δ
packages/service/src/constants.ts 100.00% <ø> (ø)
.../internal/arm-batch-rest/generated/isUnexpected.ts 93.75% <ø> (ø)
.../internal/batch-rest/generated/src/isUnexpected.ts 87.17% <ø> (ø)
packages/service/src/test-util/fakes.ts 70.40% <ø> (-1.03%) ⬇️
.../arm-batch-rest/generated/batchManagementClient.ts 80.00% <0.00%> (ø)
...c/internal/batch-rest/generated/src/batchClient.ts 82.35% <33.33%> (ø)
...nternal/batch-rest/generated/src/paginateHelper.ts 59.75% <50.00%> (-9.00%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d048540...042a30e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove edit node comms in Batch Explorer now? It's not retired until March 31, 2026.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Portal and BatchExplorer are not using node comms in shared library so it should be fine to remove it here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's under the /desktop folder, so it's not shared library and maybe used by Batch Explorer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EditNodeCommsFormComponent is used in pool-configuration.component.ts

Copy link
Member

@dpwatrous dpwatrous Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated EditNodeCommsFormComponent (and related code) to not use pool-service, so we should be good to remove any support for it in the generated SDKs

@dpwatrous dpwatrous self-requested a review November 10, 2025 21:16
Copy link
Member

@dpwatrous dpwatrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge until the change to re-add node comms is reverted, since that should no longer be necessary after #2992

@zfengms zfengms merged commit b6e9790 into main Nov 11, 2025
8 checks passed
@zfengms zfengms deleted the zfeng/generateclient20250601 branch November 11, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants