Skip to content

Removes Python from Batch Explorer#2953

Merged
gingi merged 6 commits intomainfrom
shpaster/remove-python
Dec 5, 2024
Merged

Removes Python from Batch Explorer#2953
gingi merged 6 commits intomainfrom
shpaster/remove-python

Conversation

@gingi
Copy link
Member

@gingi gingi commented Dec 4, 2024 •
edited
Loading

Removes the Python RPC server, in addition to all Python dependencies. Python SDK code sample templates remain intact.

Other notable changes:

  • The Gallery navigation item is removed post deprecation, along with Gallery-related settings
  • Folder uploading is fixed to honor local directory structure
  • Fixes UI error alerts, which were previously empty because the error response was parsed incorrectly
    Batch_Explorer

@gingi gingi force-pushed the shpaster/remove-python branch from d6ac169 to 6baea2d Compare December 4, 2024 16:52
@codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.09859% with 12 lines in your changes missing coverage. Please review.

Project coverage is 80.33%. Comparing base (13d0324) to head (8b7984d).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
desktop/src/client/core/bl-ipc-main.ts 0.00% 5 Missing ⚠️
desktop/src/app/services/azure-http.service.ts 0.00% 2 Missing ⚠️
desktop/src/app/services/file-group.service.ts 60.00% 2 Missing ⚠️
...src/@batch-flask/core/server-error/server-error.ts 83.33% 1 Missing ⚠️
desktop/src/app/models/blob-container.ts 0.00% 1 Missing ⚠️
...op/src/app/models/forms/create-form-group-model.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2953      +/-   ##
==========================================
- Coverage   80.34%   80.33%   -0.01%     
==========================================
  Files        1505     1462      -43     
  Lines       48809    46080    -2729     
  Branches     6075     5768     -307     
==========================================
- Hits        39215    37020    -2195     
+ Misses       9406     8877     -529     
+ Partials      188      183       -5
Files with missing lines Coverage Δ
...batch-flask/core/server-error/server-error.spec.ts 100.00% <100.00%> (ø)
...file/file-explorer/file-explorer.component.spec.ts 100.00% <100.00%> (ø)
...k/ui/file/file-explorer/file-explorer.component.ts 35.65% <ø> (+20.86%) ⬆️
...h-flask/ui/virtual-scroll/virtual-scroll.module.ts 100.00% <100.00%> (ø)
...ata/action/add/file-group-create-form.component.ts 12.90% <100.00%> (+2.22%) ⬆️
...d/file-group-picker/file-group-picker.component.ts 73.49% <100.00%> (-8.44%) ⬇️
...app/components/settings/settings.component.spec.ts 100.00% <ø> (ø)
.../src/app/components/settings/settings.component.ts 85.71% <100.00%> (+0.34%) ⬆️
desktop/src/app/services/aad/auth.service.spec.ts 97.76% <ø> (-0.06%) ⬇️
desktop/src/app/services/aad/auth.service.ts 92.85% <ø> (-0.17%) ⬇️
... and 12 more

... and 12 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13d0324...8b7984d. Read the comment docs.

@gingi gingi force-pushed the shpaster/remove-python branch from 801e131 to c7ea938 Compare December 5, 2024 00:13
@gingi gingi marked this pull request as ready for review December 5, 2024 00:48
@gingi gingi force-pushed the shpaster/remove-python branch from c7ea938 to 20e8227 Compare December 5, 2024 16:49
@gingi
Copy link
Member Author

gingi commented Dec 5, 2024

Fixes #2954, #2955, #2956, #2957

@gingi gingi enabled auto-merge December 5, 2024 20:00
@gingi gingi force-pushed the shpaster/remove-python branch from 4b9f0d9 to 8b7984d Compare December 5, 2024 20:52
@dpwatrous dpwatrous self-requested a review December 5, 2024 21:03
@gingi gingi merged commit 46a58ea into main Dec 5, 2024
@gingi gingi deleted the shpaster/remove-python branch December 5, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpwatrous dpwatrous dpwatrous approved these changes

@cRui861 cRui861 Awaiting requested review from cRui861 cRui861 is a code owner

@zfengms zfengms Awaiting requested review from zfengms zfengms is a code owner

@wiboris wiboris Awaiting requested review from wiboris wiboris is a code owner

@skapur12 skapur12 Awaiting requested review from skapur12 skapur12 is a code owner

@NickKouds NickKouds Awaiting requested review from NickKouds NickKouds is a code owner

@wanghoppe wanghoppe Awaiting requested review from wanghoppe wanghoppe is a code owner

@ReneOv-MSFT ReneOv-MSFT Awaiting requested review from ReneOv-MSFT ReneOv-MSFT is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gingi @dpwatrous