Merged
Conversation
gingi
requested review from
NickKouds,
ReneOv-MSFT,
cRui861,
dpwatrous,
skapur12,
wanghoppe,
wiboris and
zfengms
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2938 +/- ##
==========================================
- Coverage 80.41% 80.34% -0.08%
==========================================
Files 1504 1505 +1
Lines 48743 48800 +57
Branches 6074 6026 -48
==========================================
+ Hits 39197 39206 +9
+ Misses 9426 9406 -20
- Partials 120 188 +68
... and 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
dpwatrous
reviewed
Oct 30, 2024
...op/src/client/proxy/manual-proxy-configuration-window/manual-proxy-configuration-window.html
Show resolved
Hide resolved
dpwatrous
requested changes
Nov 1, 2024
...op/src/client/proxy/manual-proxy-configuration-window/manual-proxy-configuration-window.html
Outdated
Show resolved
Hide resolved
Adapts to Electron's ipcRenderer changes. Refactors proxy business logic and adds unit tests.
Compensates for native window title bar buttons
gingi
force-pushed
the
shpaster/remove-electron-remote
branch
from
c06158a to
c49cf1d
Compare
dpwatrous
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used deprecated Electron
remoteobject