External browser auth prompts for account selection#2928
Merged
Conversation
gingi
requested review from
NickKouds,
ReneOv-MSFT,
cRui861,
dpwatrous,
skapur12,
wanghoppe,
wiboris and
zfengms
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2928 +/- ##
==========================================
+ Coverage 67.90% 67.92% +0.01%
==========================================
Files 1271 1271
Lines 34750 34759 +9
Branches 6367 6367
==========================================
+ Hits 23598 23611 +13
+ Misses 10968 10964 -4
Partials 184 184
Continue to review full report in Codecov by Sentry.
|
|
Love this! I can now use BatchExplorer again! |
wanghoppe
approved these changes
Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users authenticating through the system browser are now presented with the account selection experience.