Skip to content

Add support for multiple repos to bux tooling#2921

Merged
skapur12 merged 1 commit intomainfrom
skapur/bux-support
Jul 16, 2024
Merged

Add support for multiple repos to bux tooling#2921
skapur12 merged 1 commit intomainfrom
skapur/bux-support

Conversation

@skapur12
Copy link
Member

@skapur12 skapur12 commented Jul 9, 2024 •
edited
Loading

Add support for multiple repositories to be used with bux operations.

These changes allow for bux to be used as a tool to symlink JavaScript modules from BatchExplorer shared libraries packages with multiple repositories (namely, the Batch Portal and CycleCloud repos).

See this work item for more context: https://msazure.visualstudio.com/AzureBatch/_workitems/edit/27253286/

What the output looks like when running the commands in the portal:

PS C:\Users\sanjanakapur\Batch-UX-Portal> node_modules/.bin/bux configure
? Path to Batch Explorer (use /mnt/c/... for WSL, e.g., CycleCloud): C:\Users\sanjanakapur\BatchExplorer
Configuration saved to C:\Users\sanjanakapur\.config\batch\bux.json

PS C:\Users\sanjanakapur\Batch-UX-Portal> node_modules/.bin/bux status   
Batch Explorer (main)
  - Path: C:\Users\sanjanakapur\BatchExplorer
  - Staged changes:
      M  util/bux/cli.ts
      M  util/bux/util.ts

Link is inactive

PS C:\Users\sanjanakapur\Batch-UX-Portal> node_modules/.bin/bux link     
Linking @azure/[email protected]
Linking @azure/[email protected]
Linking @batch/[email protected]
Linking @batch/[email protected]
Linking @batch/[email protected]

PS C:\Users\sanjanakapur\Batch-UX-Portal> node_modules/.bin/bux status
Batch Explorer (main)
  - Path: C:\Users\sanjanakapur\BatchExplorer
  - Staged changes:
      M  util/bux/cli.ts
      M  util/bux/util.ts

Link is active

PS C:\Users\sanjanakapur\Batch-UX-Portal> node_modules/.bin/bux unlink
Unlinking @azure/[email protected]
Unlinking @azure/[email protected]
Unlinking @batch/[email protected]
Unlinking @batch/[email protected]
Unlinking @batch/[email protected]
Running `npm install` to restore packages...

PS C:\Users\sanjanakapur\Batch-UX-Portal>

What the output looks like when running commands in CycleCloud:

skapur@LAPTOP-T9HUH5SN:~/cc/cyclecloud$ node_modules/.bin/bux configure
? Path to Batch Explorer (use /mnt/c/... for WSL, e.g., CycleCloud): /mnt/c/Users/sanjanakapur/BatchExplorer
Configuration saved to /home/skapur/.config/batch/bux.json

skapur@LAPTOP-T9HUH5SN:~/cc/cyclecloud$ node_modules/.bin/bux status
Batch Explorer (main)
  - Path: /mnt/c/Users/sanjanakapur/BatchExplorer
  - Staged changes:
      M  util/bux/cli.ts
      M  util/bux/util.ts

Link is inactive

skapur@LAPTOP-T9HUH5SN:~/cc/cyclecloud$ node_modules/.bin/bux link
Linking @azure/[email protected]
Linking @azure/[email protected]
skapur@LAPTOP-T9HUH5SN:~/cc/cyclecloud$ node_modules/.bin/bux status
Batch Explorer (main)
  - Path: /mnt/c/Users/sanjanakapur/BatchExplorer
  - Staged changes:
      M  util/bux/cli.ts
      M  util/bux/util.ts

Link is active

skapur@LAPTOP-T9HUH5SN:~/cc/cyclecloud$ node_modules/.bin/bux unlink
Unlinking @azure/[email protected]
Unlinking @azure/[email protected]
Running `npm install` to restore packages...
lerna notice cli v8.1.2
lerna info Bootstrapping 2 packages
lerna info Symlinking packages and binaries
lerna info lifecycle @cyclecloud/[email protected]~postinstall: @cyclecloud/[email protected]

> @cyclecloud/[email protected] postinstall /home/skapur/cc/cyclecloud/gui/pico
> patch-package

patch-package 8.0.0
Applying patches...
[email protected] ✔
lerna success Bootstrapped 2 packages

skapur@LAPTOP-T9HUH5SN:~/cc/cyclecloud$

@codecov
Copy link

codecov bot commented Jul 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.62%. Comparing base (6e52e29) to head (89ac509).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2921   +/-   ##
=======================================
  Coverage   67.62%   67.62%           
=======================================
  Files        1269     1269           
  Lines       34418    34418           
  Branches     6325     6325           
=======================================
  Hits        23276    23276           
  Misses      10970    10970           
  Partials      172      172

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e52e29...89ac509. Read the comment docs.

@skapur12 skapur12 force-pushed the skapur/bux-support branch from 3412fb1 to 89ac509 Compare July 11, 2024 19:22
gingi
gingi approved these changes Jul 15, 2024
View reviewed changes
@skapur12 skapur12 merged commit 644d334 into main Jul 16, 2024
@skapur12 skapur12 deleted the skapur/bux-support branch July 16, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gingi gingi gingi approved these changes

@cRui861 cRui861 Awaiting requested review from cRui861 cRui861 is a code owner

@dpwatrous dpwatrous Awaiting requested review from dpwatrous dpwatrous is a code owner

@zfengms zfengms Awaiting requested review from zfengms zfengms is a code owner

@wiboris wiboris Awaiting requested review from wiboris wiboris is a code owner

@NickKouds NickKouds Awaiting requested review from NickKouds NickKouds is a code owner

@wanghoppe wanghoppe Awaiting requested review from wanghoppe wanghoppe is a code owner

@ReneOv-MSFT ReneOv-MSFT Awaiting requested review from ReneOv-MSFT ReneOv-MSFT is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skapur12 @gingi