Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2920 +/- ##
==========================================
+ Coverage 67.50% 67.62% +0.12%
==========================================
Files 1262 1269 +7
Lines 34257 34418 +161
Branches 6303 6325 +22
==========================================
+ Hits 23124 23276 +152
- Misses 10963 10970 +7
- Partials 170 172 +2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
wanghoppe
requested review from
NickKouds,
ReneOv-MSFT,
cRui861,
dpwatrous,
gingi,
skapur12,
wiboris and
zfengms
as code owners
dpwatrous
reviewed
Jul 3, 2024
dpwatrous
reviewed
Jul 3, 2024
dpwatrous
reviewed
Jul 3, 2024
dpwatrous
reviewed
Jul 3, 2024
dpwatrous
reviewed
Jul 3, 2024
dpwatrous
reviewed
Jul 3, 2024
dpwatrous
requested changes
Jul 3, 2024
Member
dpwatrous
left a comment
dpwatrous
left a comment
There was a problem hiding this comment.
This looks really good overall, but I do think we need some answers around cache invalidation.
dpwatrous
reviewed
Jul 10, 2024
Member
Author
|
Regarding to return undefined when we see a 404. In real case, like in the vm extensions list blade, should we still throw an exception when the account is not found? |
dpwatrous
approved these changes
Jul 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.