Skip to content

Add commandName headers to services & rename poolResourceId#2911

Merged
wanghoppe merged 9 commits intomainfrom
hoppe/commandName
Jun 19, 2024
Merged

Add commandName headers to services & rename poolResourceId#2911
wanghoppe merged 9 commits intomainfrom
hoppe/commandName

Conversation

@wanghoppe
Copy link
Member

No description provided.

@wanghoppe wanghoppe changed the title Update Batch RLC with the latest Typespec & Add commandName headers Add commandName headers to services & rename poolResourceId Jun 7, 2024
@wanghoppe wanghoppe marked this pull request as ready for review June 7, 2024 19:12
@wanghoppe
Copy link
Member Author

/azp run BatchExplorer - CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.50%. Comparing base (fe84a1e) to head (8e5b6bd).

Current head 8e5b6bd differs from pull request most recent head 8239dcb

Please upload reports for the commit 8239dcb to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2911   +/-   ##
=======================================
  Coverage   67.50%   67.50%           
=======================================
  Files        1262     1262           
  Lines       34257    34257           
  Branches     6303     6303           
=======================================
  Hits        23124    23124           
  Misses      10963    10963           
  Partials      170      170           
Files Coverage Δ
...ckages/react/src/pool/update-node-comms-action.tsx 86.66% <100.00%> (ø)
...ckages/react/src/vm-extension/pool-vm-ext-list.tsx 84.61% <100.00%> (ø)
packages/service/src/node/live-node-service.ts 71.42% <100.00%> (ø)
packages/service/src/pool/fake-pool-service.ts 100.00% <100.00%> (ø)
packages/service/src/pool/live-pool-service.ts 85.29% <100.00%> (ø)
packages/service/src/utils.ts 85.71% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe84a1e...8239dcb. Read the comment docs.

Copy link
Member

@dpwatrous dpwatrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wanghoppe wanghoppe enabled auto-merge (squash) June 19, 2024 21:55
@wanghoppe wanghoppe merged commit dbb67f0 into main Jun 19, 2024
@wanghoppe wanghoppe deleted the hoppe/commandName branch June 19, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants