Use async iterator for node service list#2907
Merged
Conversation
List API now uses async iterator. Also some naming changes, tests.
dpwatrous
force-pushed
the
dpwatrous/node-service-refactor
branch
from
bcc224b to
03d3f22
Compare
dpwatrous
changed the title
dpwatrous
requested review from
NickKouds,
ReneOv-MSFT,
cRui861,
gingi,
skapur12,
wanghoppe,
wiboris and
zfengms
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2907 +/- ##
==========================================
+ Coverage 67.26% 67.48% +0.22%
==========================================
Files 1260 1261 +1
Lines 34210 34236 +26
Branches 6299 6303 +4
==========================================
+ Hits 23012 23105 +93
+ Misses 11033 10961 -72
- Partials 165 170 +5
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also includes some refactoring / renaming.