Add optional base URL path to environment#2904
Merged
Conversation
dpwatrous
requested review from
NickKouds,
ReneOv-MSFT,
cRui861,
gingi,
skapur12,
wanghoppe,
wiboris and
zfengms
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2904 +/- ##
==========================================
+ Coverage 67.25% 67.26% +0.01%
==========================================
Files 1259 1260 +1
Lines 34187 34210 +23
Branches 6292 6298 +6
==========================================
+ Hits 22991 23012 +21
- Misses 11032 11033 +1
- Partials 164 165 +1
Continue to review full report in Codecov by Sentry.
|
dpwatrous
force-pushed
the
dpwatrous/url-utils
branch
from
50654b1 to
6de0516
Compare
dpwatrous
force-pushed
the
dpwatrous/url-utils
branch
from
6de0516 to
6bbd50a
Compare
skapur12
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using bonito in an environment with a base path (ie: pages that define a
<base>tag), automatically normalize calls through HttpClient to include the base path if it is defined.