Make CryptoService tests use a more obviously fake key for tests#2895
Merged
Make CryptoService tests use a more obviously fake key for tests#2895
Conversation
dpwatrous
requested review from
NickKouds,
ReneOv-MSFT,
cRui861,
gingi,
skapur12,
wanghoppe,
wiboris and
zfengms
as code owners
zfengms
approved these changes
Apr 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2895 +/- ##
=======================================
Coverage 67.25% 67.25%
=======================================
Files 1259 1259
Lines 34187 34187
Branches 6291 6291
=======================================
Hits 22992 22992
Misses 11032 11032
Partials 163 163
Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current value looks too much like a real secret. Switched to a more obviously fake string.