Conversation
dpwatrous
requested review from
NickKouds,
ReneOv-MSFT,
cRui861,
gingi,
skapur12,
wanghoppe,
wiboris and
zfengms
as code owners
gingi
previously approved these changes
Apr 4, 2024
Added "trailingComma": "es5" rule to keep the effective changes minimal
dpwatrous
force-pushed
the
dpwatrous/prettier-upgrade
branch
from
eb67012 to
9242c9c
Compare
Member
Author
|
Updating was causing issues with markdownlint because of prettier's change to format *.jsonc files with trailing commas. Added overrides to prevent this. See: prettier/prettier#15956 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2893 +/- ##
=======================================
Coverage 67.29% 67.29%
=======================================
Files 1236 1236
Lines 33777 33777
Branches 6230 6230
=======================================
Hits 22729 22729
Misses 10894 10894
Partials 154 154
Continue to review full report in Codecov by Sentry.
|
gingi
approved these changes
Apr 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also contains a random package-lock.json update due to merging from stable to main.