Conversation
cRui861
requested review from
NickKouds,
ReneOv-MSFT,
dpwatrous,
gingi,
skapur12,
wanghoppe,
wiboris and
zfengms
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2891 +/- ##
==========================================
- Coverage 67.29% 67.29% -0.01%
==========================================
Files 1236 1236
Lines 33777 33777
Branches 6230 6230
==========================================
- Hits 22731 22729 -2
- Misses 10892 10894 +2
Partials 154 154 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
dpwatrous
requested changes
Mar 22, 2024
dpwatrous
reviewed
Mar 25, 2024
dpwatrous
reviewed
Mar 27, 2024
cRui861
force-pushed
the
rechen/rendering-deprecation
branch
from
128619e to
f09767d
Compare
dpwatrous
approved these changes
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pool create form no longer has the option to select a graphics or rendering OS and the application licenses have been removed.
Before:
After:
The gallery menu item remains but only holds a deprecation warning regarding the retirement of the graphics and rendering pools.
Before:
After:
