Skip to content

Merge main into stable for release 2.20.0#2881

Merged
dpwatrous merged 132 commits intostablefrom
main
Jan 12, 2024
Merged

Merge main into stable for release 2.20.0#2881
dpwatrous merged 132 commits intostablefrom
main

Conversation

@gingi
Copy link
Member

@gingi gingi commented Jan 11, 2024

No description provided.

gingi and others added 30 commits July 10, 2023 10:36
Merges changes from stable to main after release 2.18.0
* Added fake localizer

* Switch desktop app to use new translations

* Add script to combine translated files by language

* Add global build-translations command

* Update comments and docs accordingly with changes

* Run merge-translations script on Azure DevOps path

* Add localization for Batch Explorer web version

* Generate translations for Create Account buttons

* Add basic i18n support for web package

* Rename StandardLocalizer to BrowserLocalizer

* Add merge translations script for web and desktop

* Remove powershell merge translations script

* Add localization support for desktop app

* Copy translations to web too and not just desktop

* Add translations for playground buttons

* Gitignore generated localization files

* Update localization docs with setup instructions

* Add package translations to mergeTranslations

* Optimize package file creation and fix unit test

* Update Electron app localization unit tests

* Address all feedback on PR

* Fix desktop localizer, translation function, tests

* Fix Prettier issue with account yml file

* Update client translations unit test accordingly

* Add http-localizer unit test and minor fixes

* Remove CustomGlobal and simplify navigator object

* Add getLocale function to each localizer

---------

Co-authored-by: David Watrous <[email protected]>
Notarization and code signing are making the MacOS distribution
come extremely close (or over) the 60 minute default timeout.
This is currently disabled except in dev mode until the API version
which Batch Explorer uses is updated to support node comms mode.
…56a_20230804160843759. (#2774)

Co-authored-by: Shiran Pasternak <[email protected]>
* Add type safety to shared libraries localization

* Fix localization unit test

* Switch folder order of generated and localization
* Add .DS_Store to .gitignore

* Factor out bonito-core and bonito-ui

These packages are intended to act as a Batch-agnostic layer
for building Azure Portal-compatible UIs.

This also moves much of the functionality of the ui-service
package into bonito-core (specifically the parts that aren't
Batch-specific)

* Make `bux link` handle missing packages in node_modules

---------

Co-authored-by: Sanjana Kapur <[email protected]>
These have been moved to bonito-core
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* surface subForm update to parentForm

* fix: radio button doesn't update paramter value

* modify key in renderChildEntries

---------

Co-authored-by: hoppe <[email protected]>
wanghoppe and others added 19 commits December 20, 2023 23:46
* Add requiredSlots disable logic for multi-instance tasks

* Remove required slots if multi-instance is enabled

* Add required slots validation message to add-task-form

---------

Co-authored-by: hoppe <[email protected]>
* S360 Expanded-collapsed menus voiceover

* S360 Read only tab titles on tab group navigation
* AB#1065 Add aria alerts to dynamic field errors
@codecov
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (5cfd498) 67.30% compared to head (d358fab) 67.26%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #2881      +/-   ##
==========================================
- Coverage   67.30%   67.26%   -0.05%     
==========================================
  Files        1228     1228              
  Lines       33597    33620      +23     
  Branches     6204     6207       +3     
==========================================
+ Hits        22613    22615       +2     
- Misses      10838    10858      +20     
- Partials      146      147       +1     
Files Coverage Δ
desktop/src/@batch-flask/ui/tabs/tab.component.ts 100.00% <ø> (ø)
desktop/src/app/models/forms/create-task-model.ts 0.00% <0.00%> (ø)
.../src/app/services/azure-batch/file/file.service.ts 46.09% <0.00%> (-0.67%) ⬇️
...ges/bonito-ui/src/components/form/tab-selector.tsx 59.01% <37.50%> (-3.95%) ⬇️
...ponents/task/action/add/add-task-form.component.ts 14.75% <0.00%> (-3.62%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cfd498...d358fab. Read the comment docs.

@dpwatrous dpwatrous merged commit a3f074c into stable Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants