Skip to content

Add Batch RLC to service package & Add node service#2853

Merged
wanghoppe merged 21 commits intomainfrom
hoppe/batch-rest-pr
Jan 24, 2024
Merged

Add Batch RLC to service package & Add node service#2853
wanghoppe merged 21 commits intomainfrom
hoppe/batch-rest-pr

Conversation

@wanghoppe
Copy link
Member

rm batch-arm-rest package

sideeffect to false & add webpackChunkName

singleton @azure/core-util & split export batchModels and armBatchModels

remove vmextension changes

@codecov
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (a7a1e45) 67.26% compared to head (2dbbefb) 67.28%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2853      +/-   ##
==========================================
+ Coverage   67.26%   67.28%   +0.01%     
==========================================
  Files        1228     1236       +8     
  Lines       33620    33774     +154     
  Branches     6208     6182      -26     
==========================================
+ Hits        22615    22724     +109     
- Misses      10858    10896      +38     
- Partials      147      154       +7     
Files Coverage Δ
...ckages/react/src/pool/update-node-comms-action.tsx 86.66% <ø> (ø)
packages/service/src/constants.ts 100.00% <ø> (ø)
...ages/service/src/environment/batch-dependencies.ts 100.00% <100.00%> (ø)
.../internal/arm-batch-rest/__tests__/utils/client.ts 100.00% <ø> (ø)
...ages/service/src/internal/arm-batch-rest/client.ts 85.71% <100.00%> (ø)
.../arm-batch-rest/generated/batchManagementClient.ts 80.00% <ø> (ø)
.../internal/arm-batch-rest/generated/isUnexpected.ts 93.75% <ø> (ø)
...nternal/arm-batch-rest/generated/paginateHelper.ts 9.37% <ø> (ø)
...kages/service/src/internal/arm-batch-rest/index.ts 100.00% <ø> (ø)
...ce/src/internal/batch-rest/generated/src/logger.ts 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a1e45...2dbbefb. Read the comment docs.

@dpwatrous dpwatrous force-pushed the hoppe/batch-rest-pr branch from 0df74dc to 2dbbefb Compare January 23, 2024 14:21
@wanghoppe wanghoppe merged commit 1fafbc6 into main Jan 24, 2024
@wanghoppe wanghoppe deleted the hoppe/batch-rest-pr branch January 24, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants