Skip to content

add validation details and string-list control#2825

Merged
wanghoppe merged 4 commits intomainfrom
hoppe/vdetail
Nov 7, 2023
Merged

add validation details and string-list control#2825
wanghoppe merged 4 commits intomainfrom
hoppe/vdetail

Conversation

@wanghoppe
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2825 (9ba461f) into main (1b4b4e6) will increase coverage by 0.03%.
The diff coverage is 86.36%.

❗ Current head 9ba461f differs from pull request most recent head b8cc5e9. Consider uploading reports for the commit b8cc5e9 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2825      +/-   ##
==========================================
+ Coverage   67.27%   67.30%   +0.03%     
==========================================
  Files        1227     1228       +1     
  Lines       33540    33597      +57     
  Branches     6194     6203       +9     
==========================================
+ Hits        22564    22613      +49     
- Misses      10837    10838       +1     
- Partials      139      146       +7     
Files Coverage Δ
packages/bonito-core/src/form/validation-status.ts 100.00% <100.00%> (ø)
.../components/form/default-form-control-resolver.tsx 57.57% <100.00%> (+1.32%) ⬆️
packages/bonito-ui/src/components/form/index.ts 100.00% <100.00%> (ø)
packages/bonito-ui/src/hooks/use-form-parameter.ts 82.25% <75.00%> (-0.51%) ⬇️
...ages/bonito-core/src/form/string-list-parameter.ts 77.77% <57.14%> (-8.89%) ⬇️
...ages/bonito-ui/src/components/form/string-list.tsx 90.38% <90.38%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b4b4e6...b8cc5e9. Read the comment docs.

@wanghoppe wanghoppe requested a review from dpwatrous November 1, 2023 03:39
@wanghoppe wanghoppe enabled auto-merge (squash) November 7, 2023 04:25
@wanghoppe wanghoppe disabled auto-merge November 7, 2023 04:25
@wanghoppe wanghoppe enabled auto-merge (squash) November 7, 2023 04:25
@wanghoppe wanghoppe merged commit 21e7614 into main Nov 7, 2023
@wanghoppe wanghoppe deleted the hoppe/vdetail branch November 7, 2023 04:49
gingi pushed a commit that referenced this pull request Nov 9, 2023
add validation details and string-list control


---------

Co-authored-by: hoppe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants