Skip to content

Parent form's validation trigger subform validate event#2820

Merged
wanghoppe merged 2 commits intomainfrom
hoppe/refactor-validation
Oct 24, 2023
Merged

Parent form's validation trigger subform validate event#2820
wanghoppe merged 2 commits intomainfrom
hoppe/refactor-validation

Conversation

@wanghoppe
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #2820 (116bb8d) into main (f98e158) will increase coverage by 0.04%.
The diff coverage is 63.63%.

❗ Current head 116bb8d differs from pull request most recent head c39b8e8. Consider uploading reports for the commit c39b8e8 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2820      +/-   ##
==========================================
+ Coverage   66.51%   66.56%   +0.04%     
==========================================
  Files        1245     1245              
  Lines       34115    34115              
  Branches     6171     6219      +48     
==========================================
+ Hits        22692    22709      +17     
+ Misses      11286    11270      -16     
+ Partials      137      136       -1     
Files Coverage Δ
packages/bonito-core/src/form/form.ts 80.00% <ø> (ø)
packages/bonito-core/src/form/subform.ts 45.19% <100.00%> (+3.84%) ⬆️
...ackages/bonito-core/src/form/internal/form-impl.ts 88.39% <55.55%> (+5.80%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f98e158...c39b8e8. Read the comment docs.

@wanghoppe wanghoppe enabled auto-merge (squash) October 24, 2023 01:39
@wanghoppe wanghoppe merged commit 54a9e5e into main Oct 24, 2023
@wanghoppe wanghoppe deleted the hoppe/refactor-validation branch October 24, 2023 02:06
gingi pushed a commit that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants