Accessibility fixes for color contrast, link colors#2818
Merged
Conversation
Fixes AB#1137
Fixes AB#1078
dpwatrous
requested review from
NickKouds,
cRui861,
gingi,
skapur12,
wanghoppe,
wiboris and
zfengms
as code owners
dpwatrous
force-pushed
the
dpwatrous/contrast-fixes
branch
from
0314d1b to
8aa8262
Compare
Fixes AB#1097
Fixes AB#1142
dpwatrous
force-pushed
the
dpwatrous/contrast-fixes
branch
from
8aa8262 to
7492488
Compare
Codecov Report
@@ Coverage Diff @@
## main #2818 +/- ##
=======================================
Coverage 66.51% 66.51%
=======================================
Files 1245 1245
Lines 34115 34115
Branches 6170 6220 +50
=======================================
Hits 22692 22692
Misses 11286 11286
Partials 137 137 Continue to review full report in Codecov by Sentry.
|
cRui861
reviewed
Oct 19, 2023
cRui861
approved these changes
Oct 19, 2023
Member
|
Fixes #2835 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots:
Notification close button focus outline color contrast:
Calendar weekday text color contrast:
Star icon focus outline color contrast:
Subscription & resource group link colors (used to be regular text color):
Also includes a very minor alignment fix on lists to vertically center the text.
Before:
After:
