Skip to content

Minor MockHttpClient improvements#2806

Merged
dpwatrous merged 2 commits intomainfrom
dpwatrous/mock-http-bodies
Sep 25, 2023
Merged

Minor MockHttpClient improvements#2806
dpwatrous merged 2 commits intomainfrom
dpwatrous/mock-http-bodies

Conversation

@dpwatrous
Copy link
Member

@dpwatrous dpwatrous commented Sep 23, 2023

Added support for mocking UrlSearchParams bodies and fixed a minor issue where request URLs were ignored when setting expected requests.

@dpwatrous dpwatrous changed the title Add support for mocking URLSearchParams bodies Minor MockHttpClient improvements Sep 23, 2023
@dpwatrous dpwatrous disabled auto-merge September 23, 2023 18:20
@dpwatrous dpwatrous enabled auto-merge September 23, 2023 18:20
@dpwatrous dpwatrous force-pushed the dpwatrous/mock-http-bodies branch from a4185bd to 779c640 Compare September 23, 2023 18:21
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #2806 (c21282d) into main (5867065) will increase coverage by 0.00%.
The diff coverage is 84.61%.

❗ Current head c21282d differs from pull request most recent head 779c640. Consider uploading reports for the commit 779c640 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2806   +/-   ##
=======================================
  Coverage   66.48%   66.49%           
=======================================
  Files        1232     1232           
  Lines       33884    33888    +4     
  Branches     6171     6173    +2     
=======================================
+ Hits        22529    22534    +5     
+ Misses      11220    11219    -1     
  Partials      135      135           
Files Changed Coverage Δ
packages/bonito-core/src/http/mock-http-client.ts 75.00% <84.61%> (+2.27%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5867065...779c640. Read the comment docs.

@dpwatrous dpwatrous merged commit 0b3544d into main Sep 25, 2023
@dpwatrous dpwatrous deleted the dpwatrous/mock-http-bodies branch September 25, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants