Merged
Conversation
- Add getNotifier() helper function - Default to using FakeNotifier in tests - FakeNotifier doesn't require expect() calls unless opted-in
Prefer form-level errors to parameter level errors (which presumably will be shown next to their form control)
dpwatrous
requested review from
NickKouds,
cRui861,
gingi,
skapur12,
wanghoppe,
wiboris and
zfengms
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2805 +/- ##
=======================================
Coverage 66.48% 66.48%
=======================================
Files 1230 1232 +2
Lines 33816 33884 +68
Branches 6113 6172 +59
=======================================
+ Hits 22483 22529 +46
- Misses 11199 11220 +21
- Partials 134 135 +1
Continue to review full report in Codecov by Sentry.
|
gingi
approved these changes
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various additions to forms, notifications and other APIs. See individual commits in this PR for details.