Conversation
cRui861
requested review from
NickKouds,
dpwatrous,
gingi,
skapur12,
wanghoppe,
wiboris and
zfengms
as code owners
gingi
approved these changes
Oct 13, 2023
Codecov Report
@@ Coverage Diff @@
## main #2803 +/- ##
==========================================
+ Coverage 66.49% 66.54% +0.05%
==========================================
Files 1232 1240 +8
Lines 33888 33942 +54
Branches 6173 6191 +18
==========================================
+ Hits 22534 22588 +54
Misses 11219 11219
Partials 135 135
Continue to review full report in Codecov by Sentry.
|
Member
Author
|
Fixes #2834 |
gingi
pushed a commit
that referenced
this pull request
Nov 9, 2023
* WIP updating models to include new properties after data plane version update * Finish adding properties for dataplane api update * Small fix * Update VMExtension model and add in type definition for JSON
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update properties for models. Also added type definitions for JSON for issues with only an
objecttype