Skip to content

add form onEvaluate callback#2797

Merged
wanghoppe merged 2 commits intomainfrom
hoppe/subform-evaluate
Oct 27, 2023
Merged

add form onEvaluate callback#2797
wanghoppe merged 2 commits intomainfrom
hoppe/subform-evaluate

Conversation

@wanghoppe
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #2797 (82e56a7) into main (5063477) will increase coverage by 0.00%.
The diff coverage is 77.77%.

❗ Current head 82e56a7 differs from pull request most recent head 704e2b5. Consider uploading reports for the commit 704e2b5 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2797   +/-   ##
=======================================
  Coverage   66.56%   66.56%           
=======================================
  Files        1245     1245           
  Lines       34115    34122    +7     
  Branches     6170     6220   +50     
=======================================
+ Hits        22709    22714    +5     
- Misses      11270    11272    +2     
  Partials      136      136           
Files Coverage Δ
packages/bonito-core/src/form/form.ts 80.00% <ø> (ø)
...ackages/bonito-core/src/form/internal/form-impl.ts 88.54% <100.00%> (+0.15%) ⬆️
packages/bonito-ui/src/hooks/use-form.ts 91.66% <60.00%> (-8.34%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5063477...704e2b5. Read the comment docs.

@wanghoppe wanghoppe force-pushed the hoppe/subform-evaluate branch from 4c4c631 to 99ee2a0 Compare October 25, 2023 03:29
@wanghoppe wanghoppe enabled auto-merge (squash) October 27, 2023 08:55
@wanghoppe wanghoppe merged commit e4c00c1 into main Oct 27, 2023
@wanghoppe wanghoppe deleted the hoppe/subform-evaluate branch October 27, 2023 09:26
gingi pushed a commit that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants