Conversation
dpwatrous
requested review from
NickKouds,
cRui861,
gingi,
skapur12,
wanghoppe,
wiboris and
zfengms
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2794 +/- ##
==========================================
- Coverage 66.47% 66.47% -0.01%
==========================================
Files 1226 1229 +3
Lines 33707 33744 +37
Branches 6102 6158 +56
==========================================
+ Hits 22407 22431 +24
- Misses 11166 11179 +13
Partials 134 134
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
dpwatrous
force-pushed
the
dpwatrous/bonito-updates
branch
from
c7b5415 to
85555e1
Compare
This is needed for locked-down environments to avoid hitting a CDN
Applies to the default list layout
dpwatrous
force-pushed
the
dpwatrous/bonito-updates
branch
from
85555e1 to
226f484
Compare
Axe seems to trigger React state updates, which must be wrapped in act() to prevent warnings.
dpwatrous
force-pushed
the
dpwatrous/bonito-updates
branch
from
3b8abf3 to
a41ef90
Compare
skapur12
approved these changes
Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into these issues while using bonito as an external dependency.