Skip to content

fix: subForm and RadioButton bugs#2792

Merged
wanghoppe merged 3 commits intomainfrom
hoppe/fix-subform
Sep 1, 2023
Merged

fix: subForm and RadioButton bugs#2792
wanghoppe merged 3 commits intomainfrom
hoppe/fix-subform

Conversation

@wanghoppe
Copy link
Member

No description provided.

@wanghoppe wanghoppe changed the title fix: subForm and RadioParameter bugs fix: subForm and RadioButton bugs Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #2792 (198fd7c) into main (32ed427) will increase coverage by 0.02%.
The diff coverage is 58.33%.

❗ Current head 198fd7c differs from pull request most recent head 370a098. Consider uploading reports for the commit 370a098 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2792      +/-   ##
==========================================
+ Coverage   66.44%   66.47%   +0.02%     
==========================================
  Files        1226     1226              
  Lines       33699    33705       +6     
  Branches     6101     6102       +1     
==========================================
+ Hits        22392    22404      +12     
+ Misses      11175    11168       -7     
- Partials      132      133       +1     
Files Changed Coverage Δ
...ges/bonito-ui/src/components/form/radio-button.tsx 73.68% <0.00%> (+23.68%) ⬆️
...bonito-ui/src/components/form/list-form-layout.tsx 63.01% <42.85%> (+0.51%) ⬆️
packages/bonito-core/src/form/subform.ts 38.23% <100.00%> (+4.56%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32ed427...370a098. Read the comment docs.

Copy link
Member

@dpwatrous dpwatrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - love all the test updates!

@wanghoppe wanghoppe merged commit 40e6500 into main Sep 1, 2023
@wanghoppe wanghoppe deleted the hoppe/fix-subform branch September 1, 2023 14:27
gingi pushed a commit that referenced this pull request Nov 9, 2023
* surface subForm update to parentForm

* fix: radio button doesn't update paramter value

* modify key in renderChildEntries

---------

Co-authored-by: hoppe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants