Skip to content

Update many dependencies and require Node 18#2789

Merged
dpwatrous merged 1 commit intomainfrom
dpwatrous/node18
Aug 25, 2023
Merged

Update many dependencies and require Node 18#2789
dpwatrous merged 1 commit intomainfrom
dpwatrous/node18

Conversation

@dpwatrous
Copy link
Member

@dpwatrous dpwatrous commented Aug 25, 2023 •
edited
Loading

Update to the latest Electron, Karma and more. Until we upgrade to make Angular use Webpack 5, added NODE_OPTIONS=--openssl-legacy-provider to make Webpack 4 work (it depends on a legacy version of OpenSSL)

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@4952f85). Click here to learn what that means.
The diff coverage is 34.28%.

❗ Current head 54653cf differs from pull request most recent head ff8a0ee. Consider uploading reports for the commit ff8a0ee to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2789   +/-   ##
=======================================
  Coverage        ?   66.44%           
=======================================
  Files           ?     1226           
  Lines           ?    33699           
  Branches        ?     6149           
=======================================
  Hits            ?    22392           
  Misses          ?    11175           
  Partials        ?      132
Files Changed Coverage Δ
...esktop/src/@batch-flask/electron/remote.service.ts 26.66% <0.00%> (ø)
desktop/src/app/services/app-locale.service.ts 10.00% <0.00%> (ø)
...src/app/services/app-translation-loader.service.ts 16.66% <0.00%> (ø)
desktop/src/client/core/aad/auth/aad.service.ts 54.38% <0.00%> (ø)
.../src/@batch-flask/electron/electron-app.service.ts 30.76% <20.00%> (ø)
desktop/src/client/main-window/main-window.ts 23.80% <20.00%> (ø)
desktop/src/client/core/remote.ts 28.57% <28.57%> (ø)
...t/core/aad/authentication/authentication-window.ts 23.33% <50.00%> (ø)
...ration-window/manual-proxy-configuration-window.ts 22.50% <50.00%> (ø)
...oxy-credentials-window/proxy-credentials-window.ts 25.00% <50.00%> (ø)
... and 5 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4952f85...ff8a0ee. Read the comment docs.

@dpwatrous dpwatrous merged commit b2e186f into main Aug 25, 2023
@dpwatrous dpwatrous deleted the dpwatrous/node18 branch August 25, 2023 16:03
gingi pushed a commit that referenced this pull request Nov 9, 2023
@dpwatrous @gingi
Update many dependencies and require Node 18 (#2789)
2eaadc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gingi gingi gingi approved these changes

@cRui861 cRui861 Awaiting requested review from cRui861 cRui861 is a code owner

@zfengms zfengms Awaiting requested review from zfengms zfengms is a code owner

@wiboris wiboris Awaiting requested review from wiboris wiboris is a code owner

@skapur12 skapur12 Awaiting requested review from skapur12 skapur12 is a code owner

@NickKouds NickKouds Awaiting requested review from NickKouds NickKouds is a code owner

@wanghoppe wanghoppe Awaiting requested review from wanghoppe wanghoppe is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dpwatrous @gingi