Skip to content

Minor fixes and descriptive comments#2786

Merged
skapur12 merged 2 commits intomainfrom
skapur/portal-translations
Sep 6, 2023
Merged

Minor fixes and descriptive comments#2786
skapur12 merged 2 commits intomainfrom
skapur/portal-translations

Conversation

@skapur12
Copy link
Member

@skapur12 skapur12 commented Aug 24, 2023 •
edited
Loading

  • Minor fixes/descriptive comments

Everything else (including the strings) has been moved to ClientResources in the portal PR: https://msazure.visualstudio.com/One/_git/Batch-UX-Portal/pullrequest/8654322

@codecov
Copy link

codecov bot commented Aug 24, 2023 •
edited
Loading

Codecov Report

Merging #2786 (22fa2fa) into main (40e6500) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

❗ Current head 22fa2fa differs from pull request most recent head a3c54b9. Consider uploading reports for the commit a3c54b9 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2786   +/-   ##
=======================================
  Coverage   66.47%   66.47%           
=======================================
  Files        1226     1226           
  Lines       33705    33705           
  Branches     6150     6150           
=======================================
  Hits        22404    22404           
  Misses      11168    11168           
  Partials      133      133

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 054059b...a3c54b9. Read the comment docs.

@dpwatrous
Copy link
Member

dpwatrous commented Aug 24, 2023

There are some dependency ordering issues here. The bonito-* packages don't depend on any of the Batch packages, and shouldn't contain any Batch-specific strings. Can we move all of this logic to the portal's build process? Doing it in this repo seems odd.

@skapur12 skapur12 force-pushed the skapur/portal-translations branch 2 times, most recently from e7ab00f to a6003fb Compare August 29, 2023 00:39
@skapur12 skapur12 changed the title Compile package translations for use in the portal Add strings needed for portal localization Aug 29, 2023
@skapur12
Copy link
Member Author

skapur12 commented Aug 29, 2023

There are some dependency ordering issues here. The bonito-* packages don't depend on any of the Batch packages, and shouldn't contain any Batch-specific strings. Can we move all of this logic to the portal's build process? Doing it in this repo seems odd.

The logic that compiles the shared libraries package translations together has now been moved out of this PR and into the portal PR: https://msazure.visualstudio.com/One/_git/Batch-UX-Portal/pullrequest/8654322
This PR just contains the localizable strings needed for that PR

@skapur12 skapur12 force-pushed the skapur/portal-translations branch from a6003fb to f4c8ced Compare September 6, 2023 00:20
@skapur12 skapur12 changed the title Add strings needed for portal localization Minor fixes and descriptive comments Sep 6, 2023
@dpwatrous dpwatrous force-pushed the skapur/portal-translations branch from 18d9c70 to a3c54b9 Compare September 6, 2023 20:18
@skapur12 skapur12 merged commit 90fd62c into main Sep 6, 2023
@skapur12 skapur12 deleted the skapur/portal-translations branch September 6, 2023 20:52
gingi pushed a commit that referenced this pull request Nov 9, 2023
@skapur12 @gingi
Minor fixes and descriptive comments (#2786)
46a4111 
* Compile package translations for use in the portal

* Remove unneeded strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpwatrous dpwatrous dpwatrous approved these changes

@cRui861 cRui861 Awaiting requested review from cRui861 cRui861 is a code owner

@gingi gingi Awaiting requested review from gingi gingi is a code owner

@zfengms zfengms Awaiting requested review from zfengms zfengms is a code owner

@wiboris wiboris Awaiting requested review from wiboris wiboris is a code owner

@NickKouds NickKouds Awaiting requested review from NickKouds NickKouds is a code owner

@wanghoppe wanghoppe Awaiting requested review from wanghoppe wanghoppe is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skapur12 @dpwatrous