Conversation
dpwatrous
force-pushed
the
dpwatrous/bonito
branch
from
73a674e to
6be36e1
Compare
dpwatrous
requested review from
NickKouds,
cRui861,
gingi,
skapur12,
wanghoppe,
wiboris and
zfengms
as code owners
dpwatrous
force-pushed
the
dpwatrous/bonito
branch
from
6be36e1 to
314d94c
Compare
gingi
approved these changes
Aug 11, 2023
dpwatrous
force-pushed
the
dpwatrous/bonito
branch
from
314d94c to
b7161fb
Compare
Codecov Report
@@ Coverage Diff @@
## main #2781 +/- ##
==========================================
- Coverage 66.62% 66.58% -0.04%
==========================================
Files 1209 1225 +16
Lines 33751 33815 +64
Branches 6219 6225 +6
==========================================
+ Hits 22486 22517 +31
- Misses 11126 11160 +34
+ Partials 139 138 -1
... and 36 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
dpwatrous
force-pushed
the
dpwatrous/bonito
branch
2 times, most recently
from
b75db73 to
2ae590d
Compare
These packages are intended to act as a Batch-agnostic layer for building Azure Portal-compatible UIs. This also moves much of the functionality of the ui-service package into bonito-core (specifically the parts that aren't Batch-specific)
dpwatrous
force-pushed
the
dpwatrous/bonito
branch
from
2ae590d to
0b523d4
Compare
skapur12
requested changes
Aug 18, 2023
Member
skapur12
left a comment
skapur12
left a comment
There was a problem hiding this comment.
npm run loc:build is now failing due to invalid paths in LocProject.json. The copy-translations script also needs to be adjusted. Will add fixes for these
skapur12
approved these changes
Aug 19, 2023
gingi
pushed a commit
that referenced
this pull request
Nov 9, 2023
* Add .DS_Store to .gitignore * Factor out bonito-core and bonito-ui These packages are intended to act as a Batch-agnostic layer for building Azure Portal-compatible UIs. This also moves much of the functionality of the ui-service package into bonito-core (specifically the parts that aren't Batch-specific) * Make `bux link` handle missing packages in node_modules --------- Co-authored-by: Sanjana Kapur <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR factors out common functionality which is not Batch-specific into two new packages: @azure/bonito-core and @azure/bonito-ui.