Conversation
cRui861
requested review from
NickKouds,
dpwatrous,
gingi,
skapur12,
wanghoppe,
wiboris and
zfengms
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2778 +/- ##
==========================================
- Coverage 66.47% 66.45% -0.02%
==========================================
Files 1229 1232 +3
Lines 33744 33835 +91
Branches 6158 6160 +2
==========================================
+ Hits 22431 22485 +54
- Misses 11179 11216 +37
Partials 134 134
Continue to review full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here. |
Member
|
Rena, can you provide a screenshot or two of the demo? |
gingi
requested changes
Aug 16, 2023
Member
gingi
left a comment
gingi
left a comment
There was a problem hiding this comment.
The PR looks great, but I think renaming "Notification" to "Notifier" will avoid some confusion in the future.
cRui861
force-pushed
the
rechen/notif
branch
from
8105653 to
1390704
Compare
gingi
approved these changes
Sep 7, 2023
gingi
pushed a commit
that referenced
this pull request
Nov 9, 2023
* WIP Notification fakes * Move notification files over to bonito-core * Fix paths * Update naming from notification to notifier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes a notification demo in the playground for Portal and a mock notifier (for Batch Explorer).
Screenshots from the Portal playground demo:
Screenshots from web Playground demo