Merged
Conversation
skapur12
requested review from
NickKouds,
cRui861,
dpwatrous,
gingi,
wanghoppe,
wiboris and
zfengms
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2775 +/- ##
=======================================
Coverage 66.62% 66.62%
=======================================
Files 1209 1209
Lines 33750 33750
Branches 6219 6218 -1
=======================================
Hits 22485 22485
Misses 11126 11126
Partials 139 139 Continue to review full report in Codecov by Sentry.
|
dpwatrous
approved these changes
Aug 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current Insider Build, even when you switch the language, the translations still display in English. This is because after the OneLocBuild task is run, then
npm run cleanandnpm run build-translationsare run in succession in Build & Pack. (Essentially all language translations are built, then all cleaned out, then only English is built.)This PR fixes this issue by getting rid of
clean:resources(which isn’t really needed anyways since the translation files are overwritten/updated on every new build). Now the translations will stay and won’t immediately be cleaned out once built.This PR also solves the error of the translation ID appearing when you switch the language to something non-English. Before, if a string in a non-English language didn’t have a translation, it would show the ID (e.g.
application.buttons.editor). Now, it shows the English string instead (Editor).