Added support for updating node communication mode#2772
Merged
Conversation
dpwatrous
requested review from
NickKouds,
cRui861,
gingi,
skapur12,
wanghoppe,
wiboris and
zfengms
as code owners
Member
Author
|
Screenshots: Pool configuration: Edit node comms form: Success notification: |
Codecov Report
@@ Coverage Diff @@
## main #2772 +/- ##
==========================================
+ Coverage 66.42% 66.62% +0.19%
==========================================
Files 1201 1209 +8
Lines 33463 33750 +287
Branches 6112 6169 +57
==========================================
+ Hits 22227 22485 +258
- Misses 11101 11126 +25
- Partials 135 139 +4
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
dpwatrous
force-pushed
the
dpwatrous/node-comms
branch
from
6fc9187 to
c0f1e85
Compare
This is currently disabled except in dev mode until the API version which Batch Explorer uses is updated to support node comms mode.
dpwatrous
force-pushed
the
dpwatrous/node-comms
branch
from
c0f1e85 to
a4b80cb
Compare
gingi
approved these changes
Aug 4, 2023
desktop/src/app/components/common/react-action-form/react-action-form.component.spec.ts
Outdated
Show resolved
Hide resolved
desktop/src/app/components/common/react-action-form/react-action-form.component.ts
Outdated
Show resolved
Hide resolved
gingi
pushed a commit
that referenced
this pull request
Nov 9, 2023
This is currently disabled except in dev mode until the API version which Batch Explorer uses is updated to support node comms mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently disabled except in dev mode until the API version which Batch Explorer uses is updated to support node comms mode.