Fix AB#1003 Voiceover will now read aloud "+ create new file group"#2745
Merged
Fix AB#1003 Voiceover will now read aloud "+ create new file group"#2745
Conversation
cRui861
requested review from
NickKouds,
dpwatrous,
gingi,
paterasMSFT,
skapur12,
wiboris and
zfengms
as code owners
cRui861
force-pushed
the
rechen/accessibility
branch
from
9f98f1a to
d96914b
Compare
gingi
approved these changes
Jun 9, 2023
Member
gingi
left a comment
gingi
left a comment
There was a problem hiding this comment.
There are some failing unit tests, but other than making them pass, this looks great. Should make Batch Explorer forms more reliable and look better in general.
…over read-aloud when press down button
- revert file-path-navigator
cRui861
force-pushed
the
rechen/accessibility
branch
from
001f2ab to
43b989d
Compare
Codecov Report
@@ Coverage Diff @@
## main #2745 +/- ##
==========================================
- Coverage 66.27% 66.26% -0.01%
==========================================
Files 1203 1203
Lines 33515 33515
Branches 6170 6169 -1
==========================================
- Hits 22211 22210 -1
- Misses 11168 11169 +1
Partials 136 136
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
gingi
added a commit
that referenced
this pull request
Oct 27, 2023
Bug introduced in #2745: No handler for a file group that has changed. Also restores the picker option labels. Backfills container names on certain API calls because they are not returned, but are needed by various UI flows.
gingi
added a commit
that referenced
this pull request
Oct 27, 2023
Bug introduced in #2745: No handler for a file group that has changed. Also restores the picker option labels. Backfills container names on certain API calls because they are not returned, but are needed by various UI flows.
gingi
added a commit
that referenced
this pull request
Nov 1, 2023
Bug introduced in #2745: No handler for a file group that has changed. Also restores the picker option labels. Backfills container names on certain API calls because they are not returned, but are needed by various UI flows.
gingi
added a commit
that referenced
this pull request
Nov 9, 2023
Bug introduced in #2745: No handler for a file group that has changed. Also restores the picker option labels. Backfills container names on certain API calls because they are not returned, but are needed by various UI flows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bl-selectinstead ofmat-autocompletein create new batch account