Skip to content

Accessibility Fixes (332, 576, 592, 601, 598)#2738

Merged
mhdahman merged 6 commits intomainfrom
mhdahman/a11y-fixes
Jun 6, 2023
Merged

Accessibility Fixes (332, 576, 592, 601, 598)#2738
mhdahman merged 6 commits intomainfrom
mhdahman/a11y-fixes

Conversation

@mhdahman
Copy link
Contributor

@mhdahman mhdahman commented Jun 1, 2023 •
edited
Loading

This PR Fixes:

  • [Bug 332] [Visual Requirement-Batch explorer-Pools] Luminosity contrast ratio of the focusable element is less than 3:1 i.e 1.2:1.
  • [Bug 576] [Programmatic Access-Batch Explorer-Edit] On the Update the storage account blade, name and aria-expanded property are not defined for the expand and collapse button.
  • [Bug 592] [Programmatic Access-Batch Explorer-Pools-Edit tags] On the pools blade, the name is not defined for the edit tags button.
  • [Bug 601] [Programmatic Access-Batch Explorer-Pool-Nodes] The name is not defined for the toggle advanced filter button.
  • [Bug 598] [Screen Reader-Batch Explorer-Jobs-Disable] ALT is not defined for the image available on the "Are you sure you want to disable job" dialog box.

I also updated the colors of elements in the sidebar selected item for better contrast ratios:

Before After
Screenshot 2023-06-01 at 1 58 13 PM Screenshot 2023-06-01 at 1 53 45 PM
Screenshot 2023-06-01 at 1 58 04 PM Screenshot 2023-06-01 at 1 56 52 PM

@mhdahman mhdahman changed the title Accessibility Fixes (AB#332, AB#576, AB#592, AB#601, AB#598) Accessibility Fixes (332, 576, 592, 601, 598) Jun 1, 2023
@mhdahman mhdahman force-pushed the mhdahman/a11y-fixes branch from a637780 to 90a5059 Compare June 1, 2023 20:54
@mhdahman mhdahman marked this pull request as ready for review June 1, 2023 21:09
@mhdahman mhdahman force-pushed the mhdahman/a11y-fixes branch from 90a5059 to 51d98aa Compare June 1, 2023 23:43
@codecov
Copy link

codecov bot commented Jun 2, 2023 •
edited
Loading

Codecov Report

Merging #2738 (eac871a) into main (e8e5a77) will not change coverage.
The diff coverage is 100.00%.

❗ Current head eac871a differs from pull request most recent head bfdbbe1. Consider uploading reports for the commit bfdbbe1 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2738   +/-   ##
=======================================
  Coverage   66.26%   66.26%           
=======================================
  Files        1203     1203           
  Lines       33511    33511           
  Branches     6119     6169   +50     
=======================================
  Hits        22207    22207           
  Misses      11168    11168           
  Partials      136      136
Impacted Files Coverage Δ
...src/@batch-flask/ui/info-box/info-box.component.ts 100.00% <ø> (ø)
...op/src/@batch-flask/ui/info-box/info-box.module.ts 100.00% <ø> (ø)
...nts/pool/graphs/heatmap/nodes-heatmap.component.ts 95.23% <100.00%> (ø)
...phs/pool-state-graph/pool-state-graph.component.ts 97.36% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8e5a77...bfdbbe1. Read the comment docs.

@gingi gingi force-pushed the mhdahman/a11y-fixes branch from 51d98aa to 4014c98 Compare June 2, 2023 12:54
gingi
gingi reviewed Jun 2, 2023
View reviewed changes
Copy link
Member

@gingi gingi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two requests. Ping me if you need a hand with those. Otherwise, looks great.

@mhdahman mhdahman force-pushed the mhdahman/a11y-fixes branch 4 times, most recently from ee4d447 to d21ef96 Compare June 5, 2023 21:00
@mhdahman mhdahman force-pushed the mhdahman/a11y-fixes branch from 25fd02b to bfdbbe1 Compare June 6, 2023 17:51
@mhdahman mhdahman merged commit 655646f into main Jun 6, 2023
@mhdahman mhdahman deleted the mhdahman/a11y-fixes branch June 6, 2023 18:55
@cRui861 cRui861 mentioned this pull request Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gingi gingi gingi approved these changes

@cRui861 cRui861 Awaiting requested review from cRui861 cRui861 is a code owner

@dpwatrous dpwatrous Awaiting requested review from dpwatrous dpwatrous is a code owner

@zfengms zfengms Awaiting requested review from zfengms zfengms is a code owner

@paterasMSFT paterasMSFT Awaiting requested review from paterasMSFT

@wiboris wiboris Awaiting requested review from wiboris wiboris is a code owner

@skapur12 skapur12 Awaiting requested review from skapur12 skapur12 is a code owner

@NickKouds NickKouds Awaiting requested review from NickKouds NickKouds is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mhdahman @gingi