Conversation
Codecov Report
@@ Coverage Diff @@
## main #2736 +/- ##
=======================================
Coverage 66.24% 66.25%
=======================================
Files 1203 1203
Lines 33509 33518 +9
Branches 6116 6171 +55
=======================================
+ Hits 22199 22208 +9
Misses 11174 11174
Partials 136 136
Continue to review full report in Codecov by Sentry.
|
Labels weren't announced correctly because the ID wasn't set on the input elements.
Ensures aria-label on combobox includes control label and value.
gingi
requested review from
NickKouds,
cRui861,
dpwatrous,
paterasMSFT,
skapur12,
wiboris and
zfengms
as code owners
Because of quirkiness with Narrator, we place an aria-label at the option element with an explicit "selected/unselected" phrase, and set the nested content to be hidden to avoid reading twice.
Extra always shown as background-on-foreground (no colors); Sets graph to be aria-hidden.
cRui861
approved these changes
May 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.