Integrate localized strings into web and desktop app#2730
Merged
Conversation
skapur12
requested review from
NickKouds,
cRui861,
dpwatrous,
gingi,
paterasMSFT,
seth-barshay,
wiboris and
zfengms
as code owners
skapur12
force-pushed
the
dpwatrous/fake-localizer
branch
2 times, most recently
from
d12b0e8 to
0a964cd
Compare
Codecov Report
@@ Coverage Diff @@
## main #2730 +/- ##
=======================================
Coverage 66.41% 66.42%
=======================================
Files 1200 1201 +1
Lines 33430 33463 +33
Branches 6153 6161 +8
=======================================
+ Hits 22202 22227 +25
- Misses 11092 11101 +9
+ Partials 136 135 -1
Continue to review full report in Codecov by Sentry.
|
skapur12
force-pushed
the
dpwatrous/fake-localizer
branch
2 times, most recently
from
ce5b397 to
dbdd483
Compare
skapur12
force-pushed
the
dpwatrous/fake-localizer
branch
2 times, most recently
from
b916476 to
e292e0d
Compare
skapur12
force-pushed
the
dpwatrous/fake-localizer
branch
3 times, most recently
from
30b4245 to
fbb8786
Compare
dpwatrous
requested changes
Jun 7, 2023
packages/common/src/ui-common/localization/browser-localizer.ts
Outdated
Show resolved
Hide resolved
packages/react/src/ui-react/account/__tests__/create-account-action.spec.tsx
Outdated
Show resolved
Hide resolved
skapur12
force-pushed
the
dpwatrous/fake-localizer
branch
from
8044495 to
c40c07b
Compare
dpwatrous
reviewed
Jun 23, 2023
dpwatrous
reviewed
Jun 23, 2023
skapur12
force-pushed
the
dpwatrous/fake-localizer
branch
from
9ebe7ca to
23cfc1e
Compare
skapur12
force-pushed
the
dpwatrous/fake-localizer
branch
from
23cfc1e to
c8823c8
Compare
gingi
approved these changes
Jul 19, 2023
dpwatrous
reviewed
Jul 20, 2023
dpwatrous
reviewed
Jul 27, 2023
dpwatrous
requested changes
Jul 31, 2023
Member
dpwatrous
left a comment
dpwatrous
left a comment
There was a problem hiding this comment.
The changes look good to me. I'm just going to block this until we've got a portal PR ready since it contains breaking changes.
skapur12
force-pushed
the
dpwatrous/fake-localizer
branch
from
265821e to
cc8f35d
Compare
dpwatrous
approved these changes
Aug 1, 2023
gingi
pushed a commit
that referenced
this pull request
Nov 9, 2023
* Added fake localizer * Switch desktop app to use new translations * Add script to combine translated files by language * Add global build-translations command * Update comments and docs accordingly with changes * Run merge-translations script on Azure DevOps path * Add localization for Batch Explorer web version * Generate translations for Create Account buttons * Add basic i18n support for web package * Rename StandardLocalizer to BrowserLocalizer * Add merge translations script for web and desktop * Remove powershell merge translations script * Add localization support for desktop app * Copy translations to web too and not just desktop * Add translations for playground buttons * Gitignore generated localization files * Update localization docs with setup instructions * Add package translations to mergeTranslations * Optimize package file creation and fix unit test * Update Electron app localization unit tests * Address all feedback on PR * Fix desktop localizer, translation function, tests * Fix Prettier issue with account yml file * Update client translations unit test accordingly * Add http-localizer unit test and minor fixes * Remove CustomGlobal and simplify navigator object * Add getLocale function to each localizer --------- Co-authored-by: David Watrous <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.