Add deprecation warning for certificates#2728
Merged
Conversation
cRui861
requested review from
NickKouds,
dpwatrous,
gingi,
paterasMSFT,
seth-barshay,
skapur12,
wiboris and
zfengms
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2728 +/- ##
=======================================
Coverage 66.24% 66.24%
=======================================
Files 1203 1203
Lines 33499 33506 +7
Branches 6163 6167 +4
=======================================
+ Hits 22190 22195 +5
- Misses 11173 11175 +2
Partials 136 136
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
cRui861
force-pushed
the
rechen/cert-warn-banner
branch
from
c5bfb99 to
1d80eb6
Compare
dpwatrous
requested changes
May 12, 2023
desktop/src/app/components/certificate/action/add/add-certificate-form.html
Outdated
Show resolved
Hide resolved
desktop/src/app/components/certificate/action/add/add-certificate-form.html
Outdated
Show resolved
Hide resolved
- fix build issue with standard-clock
cRui861
force-pushed
the
rechen/cert-warn-banner
branch
from
81f20e8 to
7b701da
Compare
cRui861
commented
May 16, 2023
dpwatrous
approved these changes
May 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pool creation form:
Pool details > configuration > certificates:
Certificate creation form:
