Fix cloud service sku values for vm picker table#2725
Merged
Conversation
cRui861
requested review from
NickKouds,
dpwatrous,
gingi,
paterasMSFT,
seth-barshay,
skapur12,
wiboris and
zfengms
as code owners
…capability values * only show OS Disk for virtual machine skus
cRui861
force-pushed
the
rechen/cloud-service-listing-fix
branch
from
f60221e to
6662b54
Compare
dpwatrous
reviewed
May 2, 2023
Member
dpwatrous
left a comment
dpwatrous
left a comment
There was a problem hiding this comment.
The changes look good, but there's a test failure.
dpwatrous
approved these changes
May 2, 2023
Codecov Report
@@ Coverage Diff @@
## master #2725 +/- ##
=======================================
Coverage 65.08% 65.08%
=======================================
Files 916 916
Lines 26478 26490 +12
Branches 5237 5240 +3
=======================================
+ Hits 17233 17242 +9
- Misses 9245 9248 +3
Continue to review full report in Codecov by Sentry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example of what the table looked like before, with all values set to 0:
Example of the table now with correct values: