Accessibility Bug Fixes (461, 573, 604, 605, 778)#2710
Merged
Conversation
mhdahman
force-pushed
the
mhdahman/a11y-bugfixes
branch
3 times, most recently
from
9b11dff to
06d0fa7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2710 +/- ##
=======================================
Coverage 65.08% 65.09%
=======================================
Files 916 916
Lines 26490 26494 +4
Branches 5240 5240
=======================================
+ Hits 17242 17246 +4
Misses 9248 9248
Continue to review full report in Codecov by Sentry.
|
mhdahman
changed the title
mhdahman
requested review from
NickKouds,
cRui861,
dpwatrous,
gingi,
paterasMSFT,
seth-barshay,
skapur12,
wiboris and
zfengms
as code owners
gingi
force-pushed
the
mhdahman/a11y-bugfixes
branch
from
a665583 to
1db226a
Compare
gingi
previously approved these changes
May 1, 2023
gingi
force-pushed
the
mhdahman/a11y-bugfixes
branch
from
1db226a to
22c3094
Compare
mhdahman
force-pushed
the
mhdahman/a11y-bugfixes
branch
from
22c3094 to
a182ce7
Compare
mhdahman
force-pushed
the
mhdahman/a11y-bugfixes
branch
from
a182ce7 to
6686bdf
Compare
gingi
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Notable Changes
Tooltips on
bl-buttonsThis PR replaces native user-agent tooltips with mattooltips for all instances of
bl-buttonto add proper keyboard support.This also removes the
labelattributes on the button to prevent double tooltips from showing up now that tooltips are rendered bymattooltips:Although the
labelattribute is removed,mattooltipstill appliesaria-labelwith the same value as the label attribute so screen readers should still be able to announce the intended label.