Add scripts to build localization on local machine#2701
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2701 +/- ##
=======================================
Coverage ? 66.24%
=======================================
Files ? 1203
Lines ? 33459
Branches ? 6105
=======================================
Hits ? 22165
Misses ? 11158
Partials ? 136 Continue to review full report in Codecov by Sentry.
|
skapur12
force-pushed
the
feature/support-local-loc-builds
branch
from
d3de89f to
5de9dbf
Compare
skapur12
force-pushed
the
feature/support-local-loc-builds
branch
from
5de9dbf to
ea1e81c
Compare
skapur12
requested review from
NickKouds,
cRui861,
dpwatrous,
gingi,
paterasMSFT,
seth-barshay,
wiboris and
zfengms
as code owners
dpwatrous
reviewed
Apr 3, 2023
Member
dpwatrous
left a comment
dpwatrous
left a comment
There was a problem hiding this comment.
Looks really good overall - just a few comments
dpwatrous
requested changes
Apr 6, 2023
dpwatrous
approved these changes
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loc:restore,loc:build, andloc:cleanscripts to runOneLocBuildon local machine to install dependencies, build the translations, and correctly rename and move the translated files to their correct spot.RESJSONintoJSONfiles when localization is built and run locally (so we can use theJSONfiles instead for local development)destJSONparameter in build-translations scriptpackage.jsonfiles in package directories to reflect changes to build-translations script