Theme colors will only show in dev mode#2697
Merged
Conversation
cRui861
requested review from
NickKouds,
dpwatrous,
gingi,
paterasMSFT,
seth-barshay,
skapur12,
wiboris and
zfengms
as code owners
- running into issue with surfacing isDev
cRui861
force-pushed
the
rechen/theme-color-changes
branch
from
1268c0f to
d0311a1
Compare
Codecov Report
@@ Coverage Diff @@
## master #2697 +/- ##
=======================================
Coverage 65.09% 65.10%
=======================================
Files 916 916
Lines 26457 26460 +3
Branches 5231 5232 +1
=======================================
+ Hits 17223 17226 +3
Misses 9234 9234
Continue to review full report in Codecov by Sentry.
|
dpwatrous
approved these changes
Mar 30, 2023
Member
Author
|
Fixes #2714 |
gingi
added a commit
that referenced
this pull request
Apr 28, 2023
* Bumps Batch Explorer to version 2.17.0 * Restores build version string for release packaging * Fixes AB#1031: Updates vulnerable http-cache-semantics dependency Also replaced the vulnerable download module with node-downloader-helper. * Non-home tenants are inactive by default Users may opt in to authenticate specific tenants by activating them in the authentication settings page. * Merges release 2.16.1 into master (#2661) * Restores build version string for release packaging * Fixes #2659: Removes test code * Prepare for hotfix release 2.16.1 * Remove custom themes (#2663) * Fixes #2662: Restores Python backend Updated Batch CLI extensions (v9.0.0) require `azure-multiapi-storage` as explicit requirement. * Update python dependencies (#2682) * Theme colors will only show in dev mode (#2697) * Add Developer menu item and add theme colors under it - running into issue with surfacing isDev * Only show Developer menu item during developer mode * typo fix * Switch hardcoded color values to use theme colors * Fix unit tests * Remove fdescribe * Cloud Service Deprecation Warning on Pool Details (#2702) * Add banner in pools for cloud service pool deprecation * small typo fix * Fix wording * Update wording * focus first element after activating ‘Job preparation task’ * focus first interactive control in Storage accounts pane * focus first element in complex-form afterViewInit * update form-field prefix and suffix styles * update monitorChart colors * update monitor chart tooltip config * update mat-tab-group labels * fix @azure/storage-blob usage (#2709) * Add jasmine-axe for Batch Explorer unit tests (#2587) * Initial setup for jasmine axe * Add axe for accessibility testing * Add accessibility tests for a few UI components * Update package lock * Testing to see if pipeline completely passes * wip * Update package-lock * Remove console log statement * Remove failing test (fix and re-add them later) * Remove cross-env * delete metadata row * Fixes AB#950: Focus not visible for radio buttons * Fixes AB#865: Focus not visible for multiple controls * Fixes AB#990: Focus moves to background when pop-up is open * Fixes AB#702: Focus ring not visible ...when tab order reaches table for the first time without interacting with the table using the arrow keys * Fixes AB#671: When closing select dropdown with esc key the whole dialog is closed * Fixes AB#290 removing pointer events on canvas * Fixes AB#462 - Changing input boxes to bordered boxes. * Updated changelog and version. (#2719) --------- Co-authored-by: Rena <[email protected]> Co-authored-by: David Watrous <[email protected]> Co-authored-by: Waseem Dahman <[email protected]> Co-authored-by: Waseem <[email protected]> Co-authored-by: Haopeng Wang <[email protected]> Co-authored-by: “aibiber” <“[email protected]”> Co-authored-by: Robert Taft <[email protected]> Co-authored-by: robtaft-ms <[email protected]>
gingi
added a commit
that referenced
this pull request
May 1, 2023
* Restores build version string for release packaging * Fixes #2659: Removes test code * Prepare for hotfix release 2.16.1 * Release 2.17.0 (#2721) * Bumps Batch Explorer to version 2.17.0 * Restores build version string for release packaging * Fixes AB#1031: Updates vulnerable http-cache-semantics dependency Also replaced the vulnerable download module with node-downloader-helper. * Non-home tenants are inactive by default Users may opt in to authenticate specific tenants by activating them in the authentication settings page. * Merges release 2.16.1 into master (#2661) * Restores build version string for release packaging * Fixes #2659: Removes test code * Prepare for hotfix release 2.16.1 * Remove custom themes (#2663) * Fixes #2662: Restores Python backend Updated Batch CLI extensions (v9.0.0) require `azure-multiapi-storage` as explicit requirement. * Update python dependencies (#2682) * Theme colors will only show in dev mode (#2697) * Add Developer menu item and add theme colors under it - running into issue with surfacing isDev * Only show Developer menu item during developer mode * typo fix * Switch hardcoded color values to use theme colors * Fix unit tests * Remove fdescribe * Cloud Service Deprecation Warning on Pool Details (#2702) * Add banner in pools for cloud service pool deprecation * small typo fix * Fix wording * Update wording * focus first element after activating ‘Job preparation task’ * focus first interactive control in Storage accounts pane * focus first element in complex-form afterViewInit * update form-field prefix and suffix styles * update monitorChart colors * update monitor chart tooltip config * update mat-tab-group labels * fix @azure/storage-blob usage (#2709) * Add jasmine-axe for Batch Explorer unit tests (#2587) * Initial setup for jasmine axe * Add axe for accessibility testing * Add accessibility tests for a few UI components * Update package lock * Testing to see if pipeline completely passes * wip * Update package-lock * Remove console log statement * Remove failing test (fix and re-add them later) * Remove cross-env * delete metadata row * Fixes AB#950: Focus not visible for radio buttons * Fixes AB#865: Focus not visible for multiple controls * Fixes AB#990: Focus moves to background when pop-up is open * Fixes AB#702: Focus ring not visible ...when tab order reaches table for the first time without interacting with the table using the arrow keys * Fixes AB#671: When closing select dropdown with esc key the whole dialog is closed * Fixes AB#290 removing pointer events on canvas * Fixes AB#462 - Changing input boxes to bordered boxes. * Updated changelog and version. (#2719) --------- Co-authored-by: Rena <[email protected]> Co-authored-by: David Watrous <[email protected]> Co-authored-by: Waseem Dahman <[email protected]> Co-authored-by: Waseem <[email protected]> Co-authored-by: Haopeng Wang <[email protected]> Co-authored-by: “aibiber” <“[email protected]”> Co-authored-by: Robert Taft <[email protected]> Co-authored-by: robtaft-ms <[email protected]> * Bumps Batch Explorer to version 2.18.0 --------- Co-authored-by: Rena <[email protected]> Co-authored-by: David Watrous <[email protected]> Co-authored-by: Waseem Dahman <[email protected]> Co-authored-by: Waseem <[email protected]> Co-authored-by: Haopeng Wang <[email protected]> Co-authored-by: “aibiber” <“[email protected]”> Co-authored-by: Robert Taft <[email protected]> Co-authored-by: robtaft-ms <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Developer menu item in Profile which would only appear while in dev mode. Fix some hardcoded color values to use our themes.