Conversation
dpwatrous
requested review from
NickKouds,
cRui861,
gingi,
paterasMSFT,
seth-barshay,
skapur12,
wiboris and
zfengms
as code owners
dpwatrous
force-pushed
the
dpwatrous/vnext-logger
branch
4 times, most recently
from
979f4f9 to
50cf03a
Compare
This should enable us to create a logger for the portal
dpwatrous
force-pushed
the
dpwatrous/vnext-logger
branch
from
50cf03a to
35e5aae
Compare
Codecov Report
@@ Coverage Diff @@
## main #2695 +/- ##
==========================================
+ Coverage 66.18% 66.24% +0.05%
==========================================
Files 1200 1204 +4
Lines 33375 33453 +78
Branches 6089 6100 +11
==========================================
+ Hits 22090 22161 +71
- Misses 11154 11157 +3
- Partials 131 135 +4
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
gingi
approved these changes
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should enable us to create a logger for the portal.
Also added a fake clock for controlling how time advances manually.