Conversation
dpwatrous
requested review from
NickKouds,
cRui861,
gingi,
paterasMSFT,
seth-barshay,
skapur12,
wiboris and
zfengms
as code owners
Note this required reworking translation-functions a little to add stricter type checking
dpwatrous
force-pushed
the
dpwatrous/lint-fixes
branch
from
d7e8215 to
65f833d
Compare
Codecov Report
@@ Coverage Diff @@
## main #2683 +/- ##
=======================================
Coverage 66.15% 66.15%
=======================================
Files 1199 1199
Lines 33303 33303
Branches 6128 6129 +1
=======================================
Hits 22033 22033
Misses 11138 11138
Partials 132 132 Continue to review full report in Codecov by Sentry.
|
Member
Author
|
@skapur12 FYI there's a minor fix in this PR for the localization logic to merge .yml files. Previously, merging 2 YAML files like this would fail: file1.i18n.yml: foo:
bar: value onefile2.i18n.yml: foo:
baz: value twoNow this will succeed, but a conflict of the fully-qualified name will still fail. |
gingi
approved these changes
Mar 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.