Conversation
gingi
requested review from
NickKouds,
cRui861,
dpwatrous,
paterasMSFT,
seth-barshay,
skapur12,
wiboris and
zfengms
as code owners
gingi
force-pushed
the
shpaster/a11y-bugs
branch
from
5d81bcb to
e3a3bf4
Compare
Codecov Report
@@ Coverage Diff @@
## master #2629 +/- ##
==========================================
+ Coverage 65.08% 65.09% +0.01%
==========================================
Files 916 916
Lines 26420 26454 +34
Branches 5214 5230 +16
==========================================
+ Hits 17195 17221 +26
- Misses 9225 9233 +8
Continue to review full report at Codecov.
|
gingi
force-pushed
the
shpaster/a11y-bugs
branch
4 times, most recently
from
74e4448 to
a15b970
Compare
Ensures required field inputs show an asterisk and have correct ARIA markup. Also removes custom CSS from specific components. Fixes AB#553, AB#602, AB#607, AB#777, AB#875, AB#916, AB#986
Adds localization to dropdowns and bookmarks menu
Also adds localization.
gingi
force-pushed
the
shpaster/a11y-bugs
branch
from
5cef89a to
87c2a34
Compare
dpwatrous
approved these changes
Jan 27, 2023
Member
|
Fixes #2634 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several other improvements:
requiredHTML attributes)Most visible change is the removal of the light gray background of the square icon buttons.
Old:
New:
