Conversation
gingi
requested review from
NickKouds,
cRui861,
dpwatrous,
paterasMSFT,
seth-barshay,
skapur12,
wiboris and
zfengms
as code owners
gingi
force-pushed
the
shpaster/a11y-bugs
branch
from
d88af8f to
9678ca5
Compare
Codecov Report
@@ Coverage Diff @@
## master #2620 +/- ##
==========================================
+ Coverage 65.06% 65.08% +0.02%
==========================================
Files 916 916
Lines 26419 26420 +1
Branches 5213 5214 +1
==========================================
+ Hits 17189 17195 +6
+ Misses 9230 9225 -5
Continue to review full report at Codecov.
|
Was using the wrong value used by KeyboardEvent.code. Updates AB#484, AB#807, AB#803
gingi
force-pushed
the
shpaster/a11y-bugs
branch
from
f5aa131 to
6c82530
Compare
dpwatrous
requested changes
Jan 20, 2023
...rogramatic-usage/aad-credentials-picker/generate-aad-app-secret/generate-aad-app-secret.html
Outdated
Show resolved
Hide resolved
src/app/components/pool/details/pool-cost-card/pool-cost-card.html
Outdated
Show resolved
Hide resolved
Adds aria-live attribute to certain elements that convey warning status. Removes outdated warning (2019) Fixes AB#525, AB#566
Custom tooltips replaced with user-agent tooltips (title attribute)
gingi
force-pushed
the
shpaster/a11y-bugs
branch
from
7b92b5e to
727f1ca
Compare
dpwatrous
approved these changes
Jan 20, 2023
Member
|
Fixes #2634 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various accessibility bugs, most related to VoiceOver, as well as improvements to localization.