fix: announce ‘no match’ information on subscription filter#2584
Merged
fix: announce ‘no match’ information on subscription filter#2584
Conversation
wanghoppe
requested review from
cRui861,
dpwatrous,
gingi,
paterasMSFT,
seth-barshay,
skapur12,
wiboris and
zfengms
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2584 +/- ##
==========================================
- Coverage 64.99% 64.99% -0.01%
==========================================
Files 915 915
Lines 26368 26379 +11
Branches 5192 5197 +5
==========================================
+ Hits 17137 17144 +7
- Misses 9231 9235 +4
Continue to review full report at Codecov.
|
gingi
reviewed
Oct 31, 2022
Member
gingi
left a comment
gingi
left a comment
There was a problem hiding this comment.
Looks great! Great use of the LiveAnnouncer utility. Only suggestion is to localize the strings being announced.
gingi
previously approved these changes
Nov 1, 2022
Member
Author
|
@gingi I made some changes to the unit test to pass the CI check, you might need to approve it again. |
gingi
approved these changes
Nov 10, 2022
Member
|
Fixed #2634 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: AB#758