Skip to content

Add batchSupportEndOfLife to show image deprecation warnings#2574

Merged
cRui861 merged 13 commits intomasterfrom
rechen/containers-warning-2
Jan 3, 2023
Merged

Add batchSupportEndOfLife to show image deprecation warnings#2574
cRui861 merged 13 commits intomasterfrom
rechen/containers-warning-2

Conversation

@cRui861
Copy link
Member

@cRui861 cRui861 commented Sep 16, 2022 •
edited
Loading

  • Deprecation warnings will show for images that have an end of life date (batchSupportEndOfLife)
  • "Learn more" link will not show for images that don't have an associated link for users to get more information on the deprecation. Warning with date of deprecation will still appear for users.
  • Add deprecation link for WindowsServer "with-container" images

Example during pool creation:
image

Example for pool details:
image

@codecov
Copy link

codecov bot commented Sep 16, 2022 •
edited
Loading

Codecov Report

Merging #2574 (7565f7e) into master (4c5f3a5) will decrease coverage by 0.16%.
The diff coverage is 17.77%.

❗ Current head 7565f7e differs from pull request most recent head 0a1ad64. Consider uploading reports for the commit 0a1ad64 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2574      +/-   ##
==========================================
- Coverage   65.03%   64.87%   -0.17%     
==========================================
  Files         916      916              
  Lines       26406    26493      +87     
  Branches     5207     5227      +20     
==========================================
+ Hits        17174    17188      +14     
- Misses       9232     9305      +73
Impacted Files Coverage Δ
src/app/models/pool-os-skus.ts 100.00% <ø> (ø)
src/app/utils/pool-utils.ts 76.57% <10.00%> (-6.60%) ⬇️
...l/action/add/pool-create-basic-dialog.component.ts 11.42% <15.62%> (+1.24%) ⬆️
.../components/pool/details/pool-details.component.ts 17.70% <16.27%> (-2.67%) ⬇️
...icker/os-image-picker/os-image-picker.component.ts 79.74% <50.00%> (-0.52%) ⬇️
...ob/action/add/pool-picker/pool-picker.component.ts 96.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c5f3a5...0a1ad64. Read the comment docs.

dpwatrous
dpwatrous reviewed Sep 16, 2022
View reviewed changes
dpwatrous
dpwatrous reviewed Sep 16, 2022
View reviewed changes
dpwatrous
dpwatrous requested changes Sep 16, 2022
View reviewed changes
Copy link
Member

@dpwatrous dpwatrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few minor suggestions.

@cRui861 cRui861 changed the title Add deprecation warning for windowsserver container images Add batchSupportedEndOfLife to show image deprecation warnings Oct 31, 2022
@cRui861 cRui861 changed the title Add batchSupportedEndOfLife to show image deprecation warnings Add batchSupportEndOfLife to show image deprecation warnings Nov 3, 2022
@dpwatrous
Copy link
Member

dpwatrous commented Nov 3, 2022

On the pool overview, can we tweak the message slightly? Something like:

"This pool's image is nearing its end-of-life date of $DATE. After this date, new nodes may not function properly."

(This could probably use some more word-smithing)

@cRui861
Copy link
Member Author

cRui861 commented Nov 3, 2022

On the pool overview, can we tweak the message slightly? Something like:

"This pool's image is nearing its end-of-life date of $DATE. After this date, new nodes may not function properly."

(This could probably use some more word-smithing)

Kept it mostly the same but moved the actual date to the second sentence:
"This pool's image is nearing its end-of-life date. After $DATE, new nodes may not function properly."

dpwatrous
dpwatrous requested changes Nov 11, 2022
View reviewed changes
@cRui861 cRui861 force-pushed the rechen/containers-warning-2 branch from 01b39b1 to 0a1ad64 Compare December 30, 2022 18:55
@cRui861 cRui861 merged commit 82e4a3b into master Jan 3, 2023
@cRui861 cRui861 deleted the rechen/containers-warning-2 branch January 3, 2023 20:58
@cRui861
Copy link
Member Author

cRui861 commented Feb 1, 2023

Fixed #2635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpwatrous dpwatrous dpwatrous approved these changes

@gingi gingi Awaiting requested review from gingi gingi is a code owner

@zfengms zfengms Awaiting requested review from zfengms zfengms is a code owner

@paterasMSFT paterasMSFT Awaiting requested review from paterasMSFT

@seth-barshay seth-barshay Awaiting requested review from seth-barshay

@wiboris wiboris Awaiting requested review from wiboris wiboris is a code owner

@skapur12 skapur12 Awaiting requested review from skapur12 skapur12 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cRui861 @dpwatrous