Temporarily disable permissions checking on buttons#2562
Merged
Conversation
dpwatrous
requested review from
cRui861,
gingi,
paterasMSFT,
seth-barshay,
skapur12,
wiboris and
zfengms
as code owners
cRui861
previously approved these changes
Aug 26, 2022
cRui861
approved these changes
Aug 26, 2022
Codecov Report
@@ Coverage Diff @@
## master #2562 +/- ##
==========================================
- Coverage 65.00% 65.00% -0.01%
==========================================
Files 915 915
Lines 26366 26366
Branches 5190 5190
==========================================
- Hits 17139 17138 -1
- Misses 9227 9228 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Permissions checking is specifically looking for the "*" permission and doesn't handle custom roles which include specific actions like "Microsoft.Batch/batchAccounts/pools/write". Will re-enable this when the client-side permissions checking is made more robust.
Fixes #2077