Conversation
cRui861
requested review from
dpwatrous,
gingi,
paterasMSFT,
seth-barshay,
wiboris and
zfengms
as code owners
gingi
previously requested changes
Apr 28, 2022
Member
gingi
left a comment
gingi
left a comment
There was a problem hiding this comment.
This looks great. The only required change is to remove fdescribe from one of the test suites. There seem to be some other extraneous code that should probably be removed.
src/app/components/pool/graphs/heatmap/nodes-heatmap.component.ts
Outdated
Show resolved
Hide resolved
src/app/components/pool/graphs/heatmap/nodes-heatmap.component.ts
Outdated
Show resolved
Hide resolved
TODO: update legend to collapse sub-states and pick better naming for the running task slot sub-states
* colors of the categories will stay as subitem color * [WIP] need to fix running state error (showing up as black instead of green) * [WIP] need to add dropdown icon next to categories
* Change task slot colors to be more accessible
* [WIP] fix unit tests for running task overlay
cRui861
force-pushed
the
rechen/heatmap-issue
branch
from
195b6a3 to
9aa24cd
Compare
Codecov Report
@@ Coverage Diff @@
## master #2497 +/- ##
==========================================
+ Coverage 64.99% 65.00% +0.01%
==========================================
Files 914 915 +1
Lines 26348 26366 +18
Branches 5179 5190 +11
==========================================
+ Hits 17124 17139 +15
- Misses 9224 9227 +3
Continue to review full report at Codecov.
|
gingi
approved these changes
May 12, 2022
gingi
pushed a commit
that referenced
this pull request
Jul 1, 2022
* [WIP] Added new gradient colors to heatmap TODO: update legend to collapse sub-states and pick better naming for the running task slot sub-states * Categories can expand and contract now and are closed by default. * colors of the categories will stay as subitem color * [WIP] need to fix running state error (showing up as black instead of green) * [WIP] need to add dropdown icon next to categories * Fix selectState logic and add caret expansion and collapse identifier on categories * Add logic for handling task slots for running state * Change task slot colors to be more accessible * Add 100% for heatmap legend and picked colors for heatmap * clean up * Fix typo * Comment explaining state counter for running task usages * Remove whitespace * Fix unit tests * [WIP] fix unit tests for running task overlay * Fix async issue and fix state counter unit tests * Add running task slot usage tests and fix percentages * Add a few more tests for task slot usage overlay
gingi
pushed a commit
that referenced
this pull request
Jul 1, 2022
* [WIP] Added new gradient colors to heatmap TODO: update legend to collapse sub-states and pick better naming for the running task slot sub-states * Categories can expand and contract now and are closed by default. * colors of the categories will stay as subitem color * [WIP] need to fix running state error (showing up as black instead of green) * [WIP] need to add dropdown icon next to categories * Fix selectState logic and add caret expansion and collapse identifier on categories * Add logic for handling task slots for running state * Change task slot colors to be more accessible * Add 100% for heatmap legend and picked colors for heatmap * clean up * Fix typo * Comment explaining state counter for running task usages * Remove whitespace * Fix unit tests * [WIP] fix unit tests for running task overlay * Fix async issue and fix state counter unit tests * Add running task slot usage tests and fix percentages * Add a few more tests for task slot usage overlay
gingi
pushed a commit
that referenced
this pull request
Jul 1, 2022
* [WIP] Added new gradient colors to heatmap TODO: update legend to collapse sub-states and pick better naming for the running task slot sub-states * Categories can expand and contract now and are closed by default. * colors of the categories will stay as subitem color * [WIP] need to fix running state error (showing up as black instead of green) * [WIP] need to add dropdown icon next to categories * Fix selectState logic and add caret expansion and collapse identifier on categories * Add logic for handling task slots for running state * Change task slot colors to be more accessible * Add 100% for heatmap legend and picked colors for heatmap * clean up * Fix typo * Comment explaining state counter for running task usages * Remove whitespace * Fix unit tests * [WIP] fix unit tests for running task overlay * Fix async issue and fix state counter unit tests * Add running task slot usage tests and fix percentages * Add a few more tests for task slot usage overlay
gingi
pushed a commit
that referenced
this pull request
Jul 1, 2022
* [WIP] Added new gradient colors to heatmap TODO: update legend to collapse sub-states and pick better naming for the running task slot sub-states * Categories can expand and contract now and are closed by default. * colors of the categories will stay as subitem color * [WIP] need to fix running state error (showing up as black instead of green) * [WIP] need to add dropdown icon next to categories * Fix selectState logic and add caret expansion and collapse identifier on categories * Add logic for handling task slots for running state * Change task slot colors to be more accessible * Add 100% for heatmap legend and picked colors for heatmap * clean up * Fix typo * Comment explaining state counter for running task usages * Remove whitespace * Fix unit tests * [WIP] fix unit tests for running task overlay * Fix async issue and fix state counter unit tests * Add running task slot usage tests and fix percentages * Add a few more tests for task slot usage overlay
cRui861
added a commit
that referenced
this pull request
Jul 7, 2022
* Revert "Update to call List Supported Virtual Machine and Cloud Service SKUs (#2400)" This reverts commit 7e9ce2e. * Update patch version for reverting VM SKU API changes * Update changelog with hotfix information * Fix task output warning background color AB#335 * Fix border contrast of code sample package install inputs Fixes AB#291 * Fix for missing image icons Only behavior was spammed errors to the console. * Fixes AB#315: Native tooltips for gallery actions * Bumps version to 2.14.0 * Fixes silent DatetimePicker error on midnight value * Bump plist from 3.0.4 to 3.0.5 (#2493) Bumps [plist](https://github.com/TooTallNate/node-plist) from 3.0.4 to 3.0.5. - [Release notes](https://github.com/TooTallNate/node-plist/releases) - [Changelog](https://github.com/TooTallNate/plist.js/blob/master/History.md) - [Commits](https://github.com/TooTallNate/node-plist/commits) --- updated-dependencies: - dependency-name: plist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fixes AB#465: "Unselect All" navigable by keyboard * Upgrades to Electron 13 Possibly addresses issues with Conditional Access policies that require a minimum Chromium version of 91. (#2446) * Bump moment from 2.29.1 to 2.29.3 (#2496) Bumps [moment](https://github.com/moment/moment) from 2.29.1 to 2.29.3. - [Release notes](https://github.com/moment/moment/releases) - [Changelog](https://github.com/moment/moment/blob/2.29.3/CHANGELOG.md) - [Commits](moment/moment@2.29.1...2.29.3) --- updated-dependencies: - dependency-name: moment dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rena <[email protected]> * Bump minimist from 1.2.5 to 1.2.6 (#2488) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rena <[email protected]> * Bump karma from 6.3.14 to 6.3.16 (#2467) Bumps [karma](https://github.com/karma-runner/karma) from 6.3.14 to 6.3.16. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](karma-runner/karma@v6.3.14...v6.3.16) --- updated-dependencies: - dependency-name: karma dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rena <[email protected]> * Fixes issue with failed silent auth Batch Explorer would not start when an exception is thrown during silent auth that isn't an authentication error. * Updates @azure/msal-node to 1.6.0 Support for proxied environments. * Bump ejs from 3.1.6 to 3.1.7 Bumps [ejs](https://github.com/mde/ejs) from 3.1.6 to 3.1.7. - [Release notes](https://github.com/mde/ejs/releases) - [Changelog](https://github.com/mde/ejs/blob/main/CHANGELOG.md) - [Commits](mde/ejs@v3.1.6...v3.1.7) --- updated-dependencies: - dependency-name: ejs dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Fix heatmap node display issues (#2497) * [WIP] Added new gradient colors to heatmap TODO: update legend to collapse sub-states and pick better naming for the running task slot sub-states * Categories can expand and contract now and are closed by default. * colors of the categories will stay as subitem color * [WIP] need to fix running state error (showing up as black instead of green) * [WIP] need to add dropdown icon next to categories * Fix selectState logic and add caret expansion and collapse identifier on categories * Add logic for handling task slots for running state * Change task slot colors to be more accessible * Add 100% for heatmap legend and picked colors for heatmap * clean up * Fix typo * Comment explaining state counter for running task usages * Remove whitespace * Fix unit tests * [WIP] fix unit tests for running task overlay * Fix async issue and fix state counter unit tests * Add running task slot usage tests and fix percentages * Add a few more tests for task slot usage overlay * Restores native menubar on Windows In-release regression caused by upgrade to Electron 13 (3bd43c7). * Adding Sanjana as code owner * Bump async from 2.6.3 to 2.6.4 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](caolan/async@v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Bump eventsource from 1.0.7 to 1.1.1 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.0.7 to 1.1.1. - [Release notes](https://github.com/EventSource/eventsource/releases) - [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md) - [Commits](EventSource/eventsource@v1.0.7...v1.1.1) --- updated-dependencies: - dependency-name: eventsource dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Adds security linting * Minor lint fixes * Remove obsolete directives from debug config * Utility for creating a proxy environment in Azure * Installs Batch Explorer in a restricted network. * Upgrades to @azure/msal-node 1.9.0 * Uses proxy settings for authentication. * Bump node-forge from 1.0.0 to 1.3.0 Bumps [node-forge](https://github.com/digitalbazaar/forge) from 1.0.0 to 1.3.0. - [Release notes](https://github.com/digitalbazaar/forge/releases) - [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md) - [Commits](digitalbazaar/forge@v1.0.0...v1.3.0) --- updated-dependencies: - dependency-name: node-forge dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Fixes cer parsing unit test using updated forge * Microsoft mandatory file * Excludes auto-generated SECURITY.md from linting * Bumps azure-storage from 2.10.4 to 2.10.7 Fixes AB#766, AB#768: Addresses some security vulnerabilities in module dependencies (validator and json-schema). * Bumps hosted-git-info from 2.8.8 to 2.8.9 * Bumps ansi-html, normalize-url * Bumps @azure/msal-node from 1.9.0 to 1.10.0 Addresses issue with caching multiple tokens for same user (AzureAD/microsoft-authentication-library-for-js#4486). * May a11y Bug Fixes (#2520) * Fix AB#515: Narrator reports wrong Max retry count * Fix AB#516: Graphs are inaccessible in scan mode * Fix AB#517: Label is not associated with control Co-authored-by: Sanjana Kapur <[email protected]> Co-authored-by: Shiran Pasternak <[email protected]> * April a11y Bug Fixes (#2523) * Fix AB#502: The Name property of a focusable element must not be null * Fix AB#509: Focusable sibling elements must not have the same Name and LocalizedControlType Co-authored-by: Sanjana Kapur <[email protected]> * Prepare for release 2.14.0 (#2534) * Updated changelog and version. * Update changelog Co-authored-by: rechen <[email protected]> * Unrevert "Update to call List Supported Virtual Machine and Cloud Service SKUs (#2400)" 8a7424b Batch Service supports VM SKU API so reenabling service call. * Bump Batch Explorer to version 2.15.0 Co-authored-by: Shiran Pasternak <[email protected]> Co-authored-by: rechen <[email protected]> Co-authored-by: David Watrous <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Sanjana Kapur <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the UI to display task slot usage by color based on percent of the node used instead of drawing in a fill color for the node. Made changes to the heatmap legend to support dropdown menus instead of staying open with default colors for sub-states.
Previous pools heatmap legend:
Previous heatmap view:
New pools heatmap legend:
New heatmap view:
