[Re-land] Update to call List Supported Virtual Machine and Cloud Service SKUs#2456
Merged
[Re-land] Update to call List Supported Virtual Machine and Cloud Service SKUs#2456
Conversation
…2400) * Switch to using Service VM SKUs API from pulling json information from GitHub * Fix 'filter' typo * Update repo to contain vm size category list and fix unit tests
cRui861
requested review from
dpwatrous,
gingi,
paterasMSFT,
seth-barshay,
wiboris and
zfengms
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2456 +/- ##
==========================================
- Coverage 65.00% 64.98% -0.02%
==========================================
Files 914 914
Lines 26361 26345 -16
Branches 5179 5178 -1
==========================================
- Hits 17136 17121 -15
+ Misses 9225 9224 -1
Continue to review full report at Codecov.
|
gingi
approved these changes
Mar 1, 2022
Member
Author
|
Fixes #2462 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bringing back VM SKU API support.
Switch to using Service VM SKUs API from pulling json information from GitHub
Fix 'filter' typo
Update repo to contain vm size category list and fix unit tests