[Fix] Update heatmap node height calculations#2452
Merged
Conversation
cRui861
requested review from
dpwatrous,
gingi,
paterasMSFT,
seth-barshay,
wiboris and
zfengms
as code owners
cRui861
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2452 +/- ##
=======================================
Coverage 65.00% 65.00%
=======================================
Files 914 914
Lines 26359 26361 +2
Branches 5179 5179
=======================================
+ Hits 17134 17136 +2
Misses 9225 9225
Continue to review full report at Codecov.
|
dpwatrous
reviewed
Feb 23, 2022
src/app/components/pool/graphs/heatmap/nodes-heatmap.component.spec.ts
Outdated
Show resolved
Hide resolved
dpwatrous
reviewed
Feb 24, 2022
src/app/components/pool/graphs/heatmap/nodes-heatmap.component.ts
Outdated
Show resolved
Hide resolved
Contributor
|
Not really a comment for this fix, but as user I would want a hover over displaying both slots and number of tasks on the VM. More of a feature there though |
dpwatrous
approved these changes
Feb 25, 2022
Member
dpwatrous
left a comment
dpwatrous
left a comment
There was a problem hiding this comment.
Looks good - thanks for making those changes!
Member
Author
|
Fixes #2461 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requiredSlotstaskSlotsCount / taskSlotsPerNodetasktotaskSlots