Skip to content

Update dependencies, switch to Playwright#2445

Merged
dpwatrous merged 2 commits intomasterfrom
feature/electron-angular-updates
Feb 16, 2022
Merged

Update dependencies, switch to Playwright#2445
dpwatrous merged 2 commits intomasterfrom
feature/electron-angular-updates

Conversation

@dpwatrous
Copy link
Member

@dpwatrous dpwatrous commented Feb 12, 2022 •
edited
Loading

  • Updated to Electron 12, Angular 10, Typescript 4
  • Replaced Spectron with Playwright
  • Updated various other dependencies

@codecov
Copy link

codecov bot commented Feb 12, 2022 •
edited
Loading

Codecov Report

Merging #2445 (f2f4384) into master (d71d1d2) will increase coverage by 0.00%.
The diff coverage is 66.66%.

❗ Current head f2f4384 differs from pull request most recent head 62aa271. Consider uploading reports for the commit 62aa271 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2445   +/-   ##
=======================================
  Coverage   64.98%   64.98%           
=======================================
  Files         914      914           
  Lines       26345    26343    -2     
  Branches     5179     5178    -1     
=======================================
- Hits        17120    17119    -1     
+ Misses       9225     9224    -1
Impacted Files Coverage Δ
src/@batch-flask/electron/electron-app.service.ts 10.00% <0.00%> (ø)
...mponents/job/action/add/job-task-base.component.ts 16.66% <ø> (+7.97%) ⬆️
...node/browse/display/node-list-display.component.ts 61.53% <ø> (-2.75%) ⬇️
.../details/sub-tasks/list/sub-task-list.component.ts 30.76% <ø> (-4.95%) ⬇️
.../app/services/storage/blob-storage-client-proxy.ts 0.00% <ø> (ø)
...atch-flask/core/testing/timezone-testing.module.ts 61.53% <100.00%> (-2.75%) ⬇️
.../@batch-flask/ui/breadcrumbs/breadcrumb.service.ts 67.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d71d1d2...62aa271. Read the comment docs.

@dpwatrous dpwatrous mentioned this pull request Feb 12, 2022
Closed
@dpwatrous dpwatrous changed the title Update to Electron 12, Angular 10, TS 4 Updated dependencies, switch to Playwright Feb 12, 2022
@dpwatrous
Copy link
Member Author

dpwatrous commented Feb 12, 2022 •
edited
Loading

Note: combined this with my previous PR for switching to Playwright. I hit some issues with Spectron related to the Electron upgrade (not test failures) and decided not to spend the time figuring them out since Playwright works just fine and Spectron is deprecated.

@dpwatrous dpwatrous changed the title Updated dependencies, switch to Playwright Update dependencies, switch to Playwright Feb 12, 2022
@dpwatrous dpwatrous force-pushed the feature/electron-angular-updates branch 9 times, most recently from e8db2f6 to 30dc833 Compare February 16, 2022 04:41
gingi
gingi previously approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@gingi gingi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with a suggestion to either replace some Angular Material dependencies or adding a comment about the need to import an unadvertised class name.

gingi
gingi previously approved these changes Feb 16, 2022
View reviewed changes
@dpwatrous dpwatrous force-pushed the feature/electron-angular-updates branch from a569836 to 62aa271 Compare February 16, 2022 16:59
@dpwatrous dpwatrous enabled auto-merge February 16, 2022 16:59
@dpwatrous dpwatrous requested a review from gingi February 16, 2022 17:00
@dpwatrous dpwatrous merged commit 36f9e24 into master Feb 16, 2022
@dpwatrous dpwatrous deleted the feature/electron-angular-updates branch February 16, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gingi gingi gingi approved these changes

@cRui861 cRui861 Awaiting requested review from cRui861 cRui861 is a code owner

@zfengms zfengms Awaiting requested review from zfengms zfengms is a code owner

@paterasMSFT paterasMSFT Awaiting requested review from paterasMSFT

@seth-barshay seth-barshay Awaiting requested review from seth-barshay

@wiboris wiboris Awaiting requested review from wiboris wiboris is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dpwatrous @gingi