Uses private feeds for NPM and PyPi dependencies#2443
Merged
Conversation
gingi
requested review from
cRui861,
dpwatrous,
paterasMSFT,
seth-barshay,
wiboris and
zfengms
as code owners
gingi
force-pushed
the
feature/private-feed
branch
4 times, most recently
from
bbc0ce8 to
893ec3f
Compare
gingi
force-pushed
the
feature/private-feed
branch
6 times, most recently
from
548efb6 to
d128bd9
Compare
Codecov Report
@@ Coverage Diff @@
## master #2443 +/- ##
=======================================
Coverage 64.98% 64.98%
=======================================
Files 914 914
Lines 26345 26345
Branches 5179 5179
=======================================
Hits 17120 17120
Misses 9225 9225 Continue to review full report at Codecov.
|
gingi
force-pushed
the
feature/private-feed
branch
4 times, most recently
from
fb0f82a to
2177635
Compare
gingi
force-pushed
the
feature/private-feed
branch
from
2177635 to
6170658
Compare
dpwatrous
reviewed
Feb 15, 2022
gingi
force-pushed
the
feature/private-feed
branch
4 times, most recently
from
bb5793f to
e59698f
Compare
dpwatrous
previously approved these changes
Feb 16, 2022
Member
dpwatrous
left a comment
dpwatrous
left a comment
There was a problem hiding this comment.
Good stuff - approved! My other comment's definitely not a blocker so up to you on that one.
gingi
force-pushed
the
feature/private-feed
branch
from
e59698f to
49de360
Compare
dpwatrous
approved these changes
Feb 16, 2022
Member
|
Fixes #2458 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For CyberEO compliance, build and distribution pipeline now uses a private feed to manage public dependencies for both NPM and PyPi